https://bugzilla.redhat.com/show_bug.cgi?id=1947685 --- Comment #3 from Michel Alexandre Salim <michel@xxxxxxxxxxxxxxx> --- (In reply to Jerry James from comment #2) > Package Review > ============== > > Legend: > [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated > > Issues: > ======= > - Do you know why the atdj and atds META files are both empty? > no idea; should I just remove them? > - The comment on line 51, "No Scala compiler in Fedora", is incorrect. The > Scala compiler is available in the scala package. ah, somehow when I tried to find scalac I couldn't. you're right, let me reenable that > > - Would it be worthwhile to split atdgen-codec-runtime and atdgen-runtime out > as separate packages, so that consumers don't need to drag everything in to > run? sure. they're available as separate opam modules so that makes sense > > - The opam and dune-package files are in the main package. They are small > enough that that doesn't overly concern me, but they probably fit better in > the -devel subpackage. > good point. Will update, thanks -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
