https://bugzilla.redhat.com/show_bug.cgi?id=1951040 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL and Source0 addresses are usable. Ok. TODO: Update URL and Source0 to use MetaCPAN. Source0 archive (SHA-512: d7fa4d12df49e51bb110f1bfb6973df7913bbe10335f93bb07774b2d49dcf52bad1807f07e9b053be2f8a2907a49ac638bae676297672e78c8f77824b2d7af62) is original. Ok. Summary verified from lib/Test/Lib.pm. Ok. Description verified from lib/Test/Lib.pm. Ok. License verified from README, Makefile.PL, and lib/Test/Lib.pm. Ok. No XS code, noArch BuildArch is Ok. maint/Makefile.PL.include is not used. Ok. Build-time dependencies are Ok. All tests pass. Ok. $ rpmlint perl-Test-Lib.spec ../SRPMS/perl-Test-Lib-0.002-1.fc35.src.rpm ../RPMS/noarch/perl-Test-Lib-0.002-1.fc35.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint output is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-Test-Lib-0.002-1.fc35.noarch.rpm drwxr-xr-x 2 root root 0 Apr 20 11:56 /usr/share/doc/perl-Test-Lib -rw-r--r-- 1 root root 200 Aug 16 2014 /usr/share/doc/perl-Test-Lib/Changes -rw-r--r-- 1 root root 839 Aug 16 2014 /usr/share/doc/perl-Test-Lib/README -rw-r--r-- 1 root root 1539 Apr 20 11:56 /usr/share/man/man3/Test::Lib.3pm.gz drwxr-xr-x 2 root root 0 Apr 20 11:56 /usr/share/perl5/vendor_perl/Test -rw-r--r-- 1 root root 1667 Aug 16 2014 /usr/share/perl5/vendor_perl/Test/Lib.pm File layout and permissions are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Test-Lib-0.002-1.fc35.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.32.1) 1 perl(Cwd) 1 perl(File::Spec) 1 perl(lib) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsZstd) <= 5.4.18-1 Binary Requires are Ok. $ rpm -q --provides -p ../RPMS/noarch/perl-Test-Lib-0.002-1.fc35.noarch.rpm | sort -f | uniq -c 1 perl(Test::Lib) = 0.002 1 perl-Test-Lib = 0.002-1.fc35 Binary Provides are Ok. $ resolvedeps f35-build ../RPMS/noarch/perl-Test-Lib-0.002-1.fc35.noarch.rpm Binary dependencies are resolvable. Ok. The package builds in F35 (https://koji.fedoraproject.org/koji/taskinfo?taskID=66322379). Ok. The package is in line with Fedora and Perl packaging guidelines. Please consider fixing the TODO item before building this package. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
