Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: kuftp - Graphical FTP Client for KDE https://bugzilla.redhat.com/show_bug.cgi?id=386531 kevin@xxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kevin@xxxxxxxxxxxxxxxx ------- Additional Comments From kevin@xxxxxxxxxxxxxxxx 2007-11-16 13:33 EST ------- Thanks for your submission. Not a formal review as I don't have sponsorship privileges (and I haven't run this through rpmlint and the long review checklist), but here's some things I noticed: * %{_libdir}/libkuftpbookmarks.a -> This one should go away, for several reasons: 1. it's a library in what's not a -devel or -static package, 2. it's a static library, so it'd have to be treated specially (-static package, ...) and 3. I assume nothing other than kuftp itself uses it, and that links it statically, so it's just a convenience library used during build, not something worth installing. Th best way to get rid of unwanted files is to rm -f them at the end of %install. * "License: GPL" is too vague, you have to specify what version, e.g. "GPLv2", "GPLv2+" (i.e. >= 2), "GPLv3", "GPLv3+" (note that anything not including v2 is NOT a valid license for a KDE package because Qt is still GPL v2 only). (I know there's still lots of packages with "License: GPL", but these need to have their License tags fixed too.) * Source0 should be a full URL, there's a section in the guidelines for SF URLs. * Is kdebase-devel really required to build this? Or just kdelibs-devel? * Please BuildRequire kdebase3-devel or kdelibs3-devel instead of kdebase-devel or kdelibs-devel, because Rawhide is going to move to KDE 4 as the default KDE soon. The current kdelibs and kdebase packages Provide the kde*3(-devel) names. * Minor nitpick: any reason you're listing "??x??" and "???x???" rather than just "*x*" or even "*"? (That's just cosmetics though, not a requirement.) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review