https://bugzilla.redhat.com/show_bug.cgi?id=1948651 --- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> --- A standalone spec file differs from the packaged one. I will use packaged one for this review. URL and Source0 addresses are usable. Ok. TODO: Remove a trailing slash for the URL value. Source0 archive (SHA-512: e072d836d2af63200617025e21895c235ea0a81e5e1a719baa114184450a9e09eccf2642ddfb9ea4ad062c6f995aedc1aca5f467b684d173683573f3d0fab340) is original. Ok. Summary verified from lib/YAML/LibYAML/API.pm. Ok. Description verified from lib/YAML/LibYAML/API.pm. Ok. The packages contains an XS code, the package is full-arch. Ok. License verified from lib/YAML/LibYAML/API.pm, LibYAML/ppport.h, Makefile.PL, LICENSE, README. Ok. TODO: Document in the spec file a license of the bundled ./LibYAML files. It's a MIT license. FIX: Do not build-require 'libyaml'. The packages only uses libyaml-devel. FIX: Do not build-require 'perl(YAML::PP)'. It's used nowhere. TODO: Constrain 'perl(YAML::PP::Common)' build-dependency with '>= 0.024' (Makefile.PL:32). Upstream probably mistaken the two modules. TODO: Constrain 'perl(Test::More)' with '>= 0.98' (META.json:38). TODO: I recommend unsetting AUTHOR_TESTING environment variable in the %check section (t/00.compile.t:37). All tests pass. Ok. $ rpmlint perl-YAML-LibYAML-API.spec ../SRPMS/perl-YAML-LibYAML-API-0.012-1.fc35.src.rpm ../RPMS/x86_64/perl-YAML-LibYAML-API-* 4 packages and 1 specfiles checked; 0 errors, 0 warnings. $ rpm -q -lv -p ../RPMS/x86_64/perl-YAML-LibYAML-API-0.012-1.fc35.x86_64.rpm drwxr-xr-x 2 root root 0 Apr 16 11:00 /usr/lib/.build-id drwxr-xr-x 2 root root 0 Apr 16 11:00 /usr/lib/.build-id/ea lrwxrwxrwx 1 root root 70 Apr 16 11:00 /usr/lib/.build-id/ea/751a0c94108058f8599a4705ba31c83968a01d -> ../../../../usr/lib64/perl5/vendor_perl/auto/YAML/LibYAML/API/XS/XS.so drwxr-xr-x 2 root root 0 Apr 16 11:00 /usr/lib64/perl5/vendor_perl/YAML drwxr-xr-x 2 root root 0 Apr 16 11:00 /usr/lib64/perl5/vendor_perl/YAML/LibYAML drwxr-xr-x 2 root root 0 Apr 16 11:00 /usr/lib64/perl5/vendor_perl/YAML/LibYAML/API -rw-r--r-- 1 root root 5101 Sep 8 2020 /usr/lib64/perl5/vendor_perl/YAML/LibYAML/API.pm -rw-r--r-- 1 root root 312 Sep 8 2020 /usr/lib64/perl5/vendor_perl/YAML/LibYAML/API/XS.pm drwxr-xr-x 2 root root 0 Apr 16 11:00 /usr/lib64/perl5/vendor_perl/auto/YAML drwxr-xr-x 2 root root 0 Apr 16 11:00 /usr/lib64/perl5/vendor_perl/auto/YAML/LibYAML drwxr-xr-x 2 root root 0 Apr 16 11:00 /usr/lib64/perl5/vendor_perl/auto/YAML/LibYAML/API drwxr-xr-x 2 root root 0 Apr 16 11:00 /usr/lib64/perl5/vendor_perl/auto/YAML/LibYAML/API/XS -rwxr-xr-x 1 root root 31768 Apr 16 11:00 /usr/lib64/perl5/vendor_perl/auto/YAML/LibYAML/API/XS/XS.so drwxr-xr-x 2 root root 0 Apr 16 11:00 /usr/share/doc/perl-YAML-LibYAML-API -rw-r--r-- 1 root root 1533 Sep 8 2020 /usr/share/doc/perl-YAML-LibYAML-API/Changes -rw-r--r-- 1 root root 374 Sep 8 2020 /usr/share/doc/perl-YAML-LibYAML-API/README drwxr-xr-x 2 root root 0 Apr 16 11:00 /usr/share/licenses/perl-YAML-LibYAML-API -rw-r--r-- 1 root root 18349 Sep 8 2020 /usr/share/licenses/perl-YAML-LibYAML-API/LICENSE -rw-r--r-- 1 root root 1918 Apr 16 11:00 /usr/share/man/man3/YAML::LibYAML::API.3pm.gz -rw-r--r-- 1 root root 1128 Apr 16 11:00 /usr/share/man/man3/YAML::LibYAML::API::XS.3pm.gz File layout and permissions are Ok. $ rpm -q --requires -p ../RPMS/x86_64/perl-YAML-LibYAML-API-0.012-1.fc35.x86_64.rpm | sort -f | uniq -c 1 libc.so.6()(64bit) 1 libc.so.6(GLIBC_2.11)(64bit) 1 libc.so.6(GLIBC_2.2.5)(64bit) 1 libc.so.6(GLIBC_2.4)(64bit) 1 libperl.so.5.32()(64bit) 1 libpthread.so.0()(64bit) 1 libpthread.so.0(GLIBC_2.2.5)(64bit) 1 libyaml >= 0.2.5 1 libyaml-0.so.2()(64bit) 1 perl(:MODULE_COMPAT_5.32.1) 1 perl(strict) 1 perl(warnings) 1 perl(XSLoader) 1 perl(YAML::PP::Common) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsZstd) <= 5.4.18-1 1 rtld(GNU_HASH) FIX: Do not run-require 'libyaml'. The dependency is automatically generated from a library SONAME (libyaml-0.so.2()(64bit)). TODO: Constrain 'perl(YAML::PP::Common)' dependency with '>= 0.024' (Makefile.PL:32). Upstream probably mistaken the two modules. $ rpm -q --provides -p ../RPMS/x86_64/perl-YAML-LibYAML-API-0.012-1.fc35.x86_64.rpm | sort -f | uniq -c 1 perl(YAML::LibYAML::API) = 0.012 1 perl(YAML::LibYAML::API::XS) = 0.012 1 perl-YAML-LibYAML-API = 0.012-1.fc35 1 perl-YAML-LibYAML-API(x86-64) = 0.012-1.fc35 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/x86_64/perl-YAML-LibYAML-API-0.012-1.fc35.x86_64.rpm Binary dependencies are resolvable. Ok. The package does not build in F35 (https://koji.fedoraproject.org/koji/taskinfo?taskID=66052232): DEBUG package_manager.py:197: ['/usr/bin/dnf', 'builddep', '--installroot', '/var/lib/mock/f35-build-26780150-3357443/root/', '--setopt=install_weak_deps=0', '--disableplugin=local', '--disableplugin=spacewalk', '/var/lib/mock/f35-build-26780150-3357443/root//builddir/build/SRPMS/perl-YAML-LibYAML-API-0.012-1.fc35.src.rpm'] DEBUG util.py:624: child environment: None DEBUG util.py:542: Executing command: ['/usr/bin/dnf', 'builddep', '--installroot', '/var/lib/mock/f35-build-26780150-3357443/root/', '--setopt=install_weak_deps=0', '--disableplugin=local', '--disableplugin=spacewalk', '/var/lib/mock/f35-build-26780150-3357443/root//builddir/build/SRPMS/perl-YAML-LibYAML-API-0.012-1.fc35.src.rpm', '--setopt=tsflags=nocontexts'] with env {'TERM': 'vt100', 'SHELL': '/bin/bash', 'HOME': '/var/lib/mock/f35-build-26780150-3357443/root/installation-homedir', 'HOSTNAME': 'mock', 'PATH': '/usr/bin:/bin:/usr/sbin:/sbin', 'PROMPT_COMMAND': 'printf "\\033]0;<mock-chroot>\\007"', 'PS1': '<mock-chroot> \\s-\\v\\$ ', 'LANG': 'C.UTF-8', 'LC_MESSAGES': 'C.UTF-8', 'LD_PRELOAD': '/var/tmp/tmp.mock.f4hua02m/$LIB/nosync.so'} and shell False DEBUG util.py:444: No matches found for the following disable plugin patterns: local, spacewalk DEBUG util.py:446: Package coreutils-8.32-22.fc35.x86_64 is already installed. DEBUG util.py:446: Package findutils-1:4.8.0-2.fc34.x86_64 is already installed. DEBUG util.py:444: Error: DEBUG util.py:444: Problem: package perl-devel-4:5.32.1-474.fc35.x86_64 requires redhat-rpm-config, but none of the providers can be installed DEBUG util.py:444: - package redhat-rpm-config-183-1.fc35.noarch requires (annobin if (gcc or clang)), but none of the providers can be installed DEBUG util.py:444: - conflicting requests We need to wait until the build root is fixed. Otherwise the package is in line with Fedora and Perl packaging guidelines. Resolution: NOT approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
