https://bugzilla.redhat.com/show_bug.cgi?id=1948659 Kalev Lember <klember@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+ --- Comment #7 from Kalev Lember <klember@xxxxxxxxxx> --- Looks good to me! Licensing looks good and the package follows the packaging standards. Just two tiny nits that are not blockers for the review: > %autosetup -S git -n %{name}-40.alpha You can use %{tarball_version} instead of hardcoding 40.alpha here > %package -n %{name}-search-appliance A shorter form of this is '%package search-appliance' which avoids '-n %{name}-' APPROVED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
