Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: alienarena - 3d Deathmatch game https://bugzilla.redhat.com/show_bug.cgi?id=371411 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2007-11-16 11:06 EST ------- Well, for 6.10-3: * alienarena.src: W: strange-permission alienarena.sh 0775 - All files in src should have 0644 permission. Change permissons when you actually install. * Timestamps - Please use "-p" option to keep timestamps when using "cp" or "install" commands (for SOURCE3, SOURCE1) * Location of the binaries - By the way, if crded or crx.sdl is not directly called, it may well that these binaries are moved under %_libexecdir. * W: unstripped-binary-or-object /usr/lib/alienarena/game.so ------------------------------------------------------ install -m0644 release/game.so $RPM_BUILD_ROOT%{_libdir}/alienarena/ ------------------------------------------------------ - find-debuginfo.sh or so won't strip binaries if they don't have executable permission. If you want 0644 permission for this, perhaps - once install with 0755 permission - later, set permission by %attr would work properly? (I have not checked this). * defattr - We now recommend %defattr(-,root,root,-) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review