https://bugzilla.redhat.com/show_bug.cgi?id=1945771 Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST Assignee|nobody@xxxxxxxxxxxxxxxxx |zebob.m@xxxxxxxxx Flags|needinfo?(zebob.m@xxxxxxxxx |fedora-review+ |) | --- Comment #9 from Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> --- (In reply to Brian Lane from comment #8) > Spec URL: https://bcl.fedorapeople.org/weldr-client/weldr-client.spec > SRPM URL: > https://bcl.fedorapeople.org/weldr-client/weldr-client-35.0-3.fc32.src.rpm > Description: Command line utility to control osbuild-composer > Fedora Account System Username: bcl > > > > Thanks for your patience, I think this is now all cleaned up for Fedora at > least. > > The rhel checks are there for RHEL9, which I hope is closer to Fedora > behavior than RHEL8 was, but I haven't had a chance to setup a VM to test it > on yet so I didn't change any of that. > I hope so. > I don't think cobra/doc needs to be a separate BuildRequire, it comes from > the same package as cobra. I did fix the testify modules though. In general > how do you decide what to list in BuildRequires? I was using the go.mod > direct dependencies as my guide, but obviously that doesn't match how Fedora > is packaging things. > With go2rpm you can list all import path used. Sometimes we have to split a package/import path into separate subpackages to work around cyclic dependencies. > Thanks for the explanation of the build flags, I rearranged the way I did > because the Makefile needs to also work standalone so it's better to just > duplicate things in the spec and pass them as part of GOBUILDFLAGS. Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
