https://bugzilla.redhat.com/show_bug.cgi?id=1946071 --- Comment #4 from Michal Ambroz <rebus@xxxxxxxxx> --- Thank you for review and comments. Updated package Spec URL: https://rebus.fedorapeople.org/SPECS/libemu.spec SRPM URL: https://rebus.fedorapeople.org/SRPMS/libemu-0.2.0-18.20130410gitab48695.fc33.src.rpm > Shouldn't you use %bcond_without within the Fedora condition? Py2 package are not allowed in Fedora anymore. py2 package is there for the RHEL7 where py2 module was already released in the past py3 module is not working at the point, I hope to include it once it is ready - hence the conditions so I can try easily just by passing the argument > - You get the archive from DinoTools but you point the URL to buffer: Thanks for spotting - this is wrong, changed back to DinoTools. I plan to migrate to buffer's repository in the future - it looks more living than the DinoTools, but it is not ready yet to switch over. > - make %{?_smp_mflags} → %make_build OK > - Why is this touching needed: It was ignoring the failed python3 build ... but you are right, this should go away and package build should fail if part is failing. > - This is not needed anymore: %ldconfig_scriptlets Still needed for EPEL7 ... I will state that explicit > - Globbing the entire %{python2_sitearch}/* and %{python3_sitearch}/* is now forbidden, please be more specific instead OK > - In order to avoid unintentional soname bump, we recommend not globbing the major soname version, please be more specific here too: OK > - please remove the trailing spaces throughout the SPEC removed > AutoTools: Obsoleted m4s found AM_CONFIG_HEADER AC_PROG_LIBTOOL Already part of patch 14 >- Please BR gcc and make explicitly >- If your application is a C or C++ application you must list a OK added. GCC was actually brought by libtool, but better to state that explicitly >- Package does not use a name that already exists. Note: A package with this name already exists. Yes ... that is the same package. Was kicked from rawhide due to FTBFS. Now trying to return. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
