[Bug 1896742] Review Request: python3-radexreader - Reader for the RADEX RD1212 Geiger counter

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1896742



--- Comment #16 from code@xxxxxxxxxxx <code@xxxxxxxxxxx> ---
Yesterday, I tried to build the RPM for OpenSuse with my SPEC, and I found two
mistakes.

First, I think that:
> Requires: python3dist(pyusb)
> Requires: python3dist(pyserial)
is wrong.

In guidelines I see:
> These Provides tags can be used to list Requires and BuildRequires of a package using the standardized names
> (i.e. dist name, name on PyPI) of Python modules. To make it easier, you can use the %{py3_dist} macro that
> accept one or more parameters: the standardized name(s) of the desired Python software. It will convert the
> name(s) to the canonical format and create the proper python3dist(...) tag(s).

So I updated to:
> Requires: %{py3_dist pyusb}
> Requires: %{py3_dist pyserial}

Secondly:
> BuildRequires: python3-devel
> Requires: python3
> Requires: %{py3_dist pyusb}
> Requires: %{py3_dist pyserial}

I moved them inside %package (after summary).
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_example_python_spec_file


Here is the updated spec:
https://gist.githubusercontent.com/luigifab/e2f77892bfc27185571d3731be4e422f/raw/383301a771f50556d4b77a4d8c4899a057c70d65/python-radexreader-fedora.spec
Here is the updated Koji build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=65382127
And the updated SRPM:
https://kojipkgs.fedoraproject.org//work/tasks/2135/65382135/python-radexreader-1.1.0-1.fc35.src.rpm


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux