https://bugzilla.redhat.com/show_bug.cgi?id=1946365 --- Comment #3 from Benjamin Gilbert <bgilbert@xxxxxxxxxx> --- Thanks for the reviews! > - Remove: > > %gopkg > > since you're not including it in %files, I guess you don't need it as a library. Done. > %global gomodulesmode GO111MODULE=on Ah, great, I don't think that existed when FCCT was first packaged. Done. > export GOOS=darwin > export GOARCH=amd64 > %gobuild -o butane-x86_64-apple-darwin internal/main.go Unfortunately that doesn't seem to work for cross builds: /usr/lib/golang/pkg/tool/linux_amd64/link -o $WORK/b001/exe/a.out -importcfg $WORK/b001/importcfg.link -installsuffix shared -buildmode=pie -buildid=9wVtOu_M646dIl94S3eg/0oAfqKUuLR0ccS8QGUu2/ddJaS9ygXJ8nNUSB7BfF/9wVtOu_M646dIl94S3eg -X github.com/coreos/butane/internal/version.Raw=0.11.0 -X github.com/coreos/butane/version=0.11.0 -B 0x0639699e6466d45b198add371c7e00b3788f0cc2 -extldflags "-Wl,-z,relro -Wl,--as-needed -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld " -extld=gcc $WORK/b001/_pkg_.a # command-line-arguments /usr/lib/golang/pkg/tool/linux_amd64/link: running gcc failed: exit status 1 /usr/bin/ld: cannot find 1144: No such file or directory /tmp/go-link-378017167/go.o: file not recognized: file format not recognized collect2: error: ld returned 1 exit status > - One test fails on 32 bits arches: Whoops, good catch. That's an old bug that was uncovered by a new test in 0.11.0. Fixed. > the description could probably be updated to not talk just about FCOS now that we're trying to be more generic. Done. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
