https://bugzilla.redhat.com/show_bug.cgi?id=1941896 Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@xxxxxxxxxxxxxxxxx |zebob.m@xxxxxxxxx Flags| |fedora-review? --- Comment #10 from Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> --- - /etc → %{_sysconfdir} - Use install -p to keep timestamps - Why are you doing this: cp conf/rudo ~/ cp conf/rudo.conf ~/ cp man/rudo.1 ~/ cp man/rudo.conf.5 ~/ instead of just installing them from their current location? mkdir -p %{buildroot}%{_sysconfdir} mkdir -p %{buildroot}%{_sysconfdir}/pam.d/ mkdir -p %{buildroot}%{_mandir}/man1 mkdir -p %{buildroot}%{_mandir}/man5 install -pm 0640 cp conf/rudo.conf %{buildroot}%{_sysconfdir}/rudo.conf install -pm 0644 conf/rudo %{buildroot}%{_sysconfdir}/pam.d/rudo install -pm 0644 man/rudo.1 %{buildroot}%{_mandir}/man1/rudo.1 install -pm 0644 man/rudo.conf.5 %{buildroot}%{_mandir}/man5/rudo.conf.5 - This is not needed anymore: echo "pam-devel" echo "systemd-devel" pam-devel is implied by the rust-pam-sys dep and systemd-devel by the rust-libsystemd-sys dep - License ok - Latest version packaged - Builds in mock - No rpmlint errors - Conforms to Packaging Guidelines -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
