https://bugzilla.redhat.com/show_bug.cgi?id=1943526 Otto Urpelainen <oturpe@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(alciregi@posteo.n | |et) --- Comment #9 from Otto Urpelainen <oturpe@xxxxxx> --- I found one important issue still. I apologize for not bringing this up earlier, I simply missed it before now: - Shared object should not be installed with glob %{_libdir}/%{name}.so.*, %{_libdir}/%{name}.so.2* would be better to avoid accidentally making an abi breaking update. Reference: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_listing_shared_library_files An then two minor items I just note but will not insist on: - -devel package description mentions static libary files, but none are installed. Perhaps that part can be omitted. - API.md would fit -devel package docs better, since it is interesting only for development. Reference: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_documentation say this: > For example API documentation belongs in the -devel subpackage, not the main one. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
