https://bugzilla.redhat.com/show_bug.cgi?id=1945613 --- Comment #1 from Jaroslav Škarvada <jskarvad@xxxxxxxxxx> --- (In reply to Richard Lescak from comment #0) > Known problems: > > Rpmlint on installed packages: > pappl.x86_64: W: libdlunused-direct-shlib-dependency > /usr/lib64/libpappl.so.1 /lib64/libdl.so.2 > pappl.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libpappl.so.1 > /lib64/libz.so.1 > I think it could be resolved with the -Wl,--as-needed. Probably the Makefile could be patched to build with the LDFLAGS. I didn't check it thoroughly, but it seems LDFLAGS are not used. > Koji building only without testsuite ("make test" commented out in .spec > file - trying to identify missing requirements which are probably the cause) > There should be description why it is disabled. If the testsuite is failing and if it could be fixed, there should be link to upstream bug/PR. Other issues found: - I think it's not ASL 2.0 license, but ASL 2.0 with exceptions, I think it should be consulted with the Fedora Legal and such license should be probably added to the list of allowed licenses - several spurious whitespaces after the line ends - inconsistent two lines space before %changelog, other sections are delimited by just one line space - spurious line space before the EOF - %set_build_flags seems redundant, I think all required flags are set by the %configure macro - 'make install', why not use macro %make_install? - unowned directories: /usr/share/pappl, /usr/include/pappl Note: The static lib seems to be used by the testsuite and it seems its installation cannot be disabled, so its removal in the %install is correct. Maybe upstream bug/PR could be created allowing disablement of the static lib installation. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
