https://bugzilla.redhat.com/show_bug.cgi?id=1943526 Otto Urpelainen <oturpe@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(alciregi@posteo.n | |et) --- Comment #5 from Otto Urpelainen <oturpe@xxxxxx> --- Great, it is getting better. Another set of findings still: - Main package documentation could be added: AUTHORS, ChangeLog, README - Documentation for -devel: - There is %{_pkgdocdir} which resolves to %{_docdir}/%{name} - But do not do that if also %doc is used, reference: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_documentation - At the moment, part of the material goes to /usr/share/doc/libuev, other part to /usr/share/doc/libuev-devel. Everything marked as -devel package docs should go to -devel directory. I think using %doc only would correct this. - In examples, .gitignore is not useful and should not be included. Probably the same also holds for Makefiles - Directories without known owners: /usr/share/doc/libuev I think this comes from the problem above where -devel installs docs to main package's directory. You could run fedora-review after the changes and see if the error remains. Or submit the new files and I will run it as usual. Reference: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_file_and_directory_ownership I slightly worry over licensing and libuev-2.3.2/src/bench.c which has different license and copyright owner than the rest. But, it seem to be built separately from the library and not installed, so it does not require License entry for binary rpm, and includes the license in the file itself, so source rpm licensing is ok as well. So, I think it can be like it is. Apart from these, everything looks good. fedora-review was unable to download Source, but perhaps that was a transient failure. I will ignore that for now and see how it goes for the next version. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
