[Bug 1944554] Review Request: perl-Glib-IO - Perl binding to the GIO library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1944554

Jitka Plesnikova <jplesnik@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |jplesnik@xxxxxxxxxx
              Flags|                            |fedora-review+



--- Comment #7 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> ---
(In reply to Michal Josef Spacek from comment #6)
> (In reply to Petr Pisar from comment #5)
> > The usage is this one:
> > 
> >   my $loop = Glib::MainLoop->new ();
> > 
> > That does not load Glib module. The test just expects that Glib::MainLoop
> > was imported
> > implicitly somewhere somehow (probably by Glib transitively loaded by "use
> > Glib::IO;"
> > at line #5). It's maybe a deficiency in the test, but the RPM dependency
> > should not be there:
> 
> Yes, you are right.
> I removed this dependency.
> 
> https://skim.cz/tmp/perl-Glib-IO-2/perl-Glib-IO.spec
> https://skim.cz/tmp/perl-Glib-IO-2/perl-Glib-IO-0.001-1.fc35.src.rpm
> 
> Thanks.

 # Tests:
-BuildRequires:  perl(Glib)
 BuildRequires:  perl(Test::More)

Package looks good now.

Resolution:
Approved


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux