https://bugzilla.redhat.com/show_bug.cgi?id=1942392 --- Comment #7 from Connor Kuehl <ckuehl@xxxxxxxxxx> --- (In reply to Fabiano Fidêncio from comment #6) > [..] > [!]: License file installed when any subpackage combination is installed. > Sergio, license is only being installed as part of the > rust-vmm-sys-util-devel package. I think the root `rust-vmm-sys-util-devel` is required by the other subfeature versions, so running `dnf install rust-vmm-sys-util+serde-devel` should result in rust-vmm-sys-util-devel being installed with the license. Is that sufficient? > [..] > [?]: Fully versioned dependency in subpackages if applicable. > Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rust- > vmm-sys-util-devel , rust-vmm-sys-util+default-devel , rust-vmm-sys- > util+serde-devel , rust-vmm-sys-util+serde_derive-devel , rust-vmm- > sys-util+with-serde-devel > Segio, it looks good to me as it is, but I'd like a second check from > Connor here. Fabiano, I believe you're correct. This looks good to me. > [..] > [?]: Package functions as described. > Sergio, I haven't tested the package, I'd appreciate if Connor could do. I have a package that only transiently depends on vmm-sys-util for unit tests, but a lot of the other required packages aren't packaged for Fedora yet since they depend on this one. So I think it would be nontrivial for me to position my other package to test this library. The unit tests that run for this package are all passing, which is good enough for me. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
