https://bugzilla.redhat.com/show_bug.cgi?id=1941896 Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@xxxxxxxxx Doc Type|--- |If docs needed, set a value --- Comment #2 from Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> --- - The LICENSE file must be installed with %license in %files %files -n %{crate} %doc README.md %license LICENSE %{_bindir}/rudo %endif […] %files devel %doc README.md %license LICENSE %{cargo_registry}/%{crate}-%{version_no_tilde}/ - The configuration files are not installed? You need to BuildRequires: pam-devel and install the pam file conf/rudo to %{buildroot}%{_sysconfdir}/pam.d/rudo %config(noreplace) %{_sysconfdir}/pam.d/rudo A default configuration file should probably be installed with wheel permission enabled. If this is auto generated at startup, I'd still recommend to add %ghost directive so the file is taken care of when uninstalling. %ghost %{_sysconfdir}/rudo.conf - You should set suid in %files: %attr(4755,root,root) %{_bindir}/rudo - The documentation for the config file is not very clear. Consider writing a man page. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
