https://bugzilla.redhat.com/show_bug.cgi?id=1942392 --- Comment #2 from Connor Kuehl <ckuehl@xxxxxxxxxx> --- Hi Sergio! Overall it looks good. Just a few requested changes: 1. The vmm-sys-util-fix-metadata.diff should be sent upstream, otherwise their crates.io package is needlessly including that CI stuff 1.1. This diff doesn't do what it looks like it should do. Since upstream doesn't exclude this in their manifest, patching it out here is too late, as it's already included in the *.crate source tarball. I suspect you'll want to update this patch to actually remove the rust-vmm-ci/ directory and the /coverage_config_* files. 2. I think the other patch, vmm-sys-util-omit-ioctl-tests.diff, is fine, but if you wanted to, you can automatically patch out the tests by changing '%bcond_without check' to '%bcond_with check' in the .spec file which would mean that this patch could also be removed. This isn't a required change for this review though. 3. The %license field is missing 4. The changelog is slightly different than one of the prescribed formats (https://docs.fedoraproject.org/en-US/packaging-guidelines/#changelogs). I've been wondering if rust2rpm should stop putting the HH:MM:SS timestamp in the changelog entry. It's on my list to ask the other Rust packagers + upstream rust2rpm. Please address points #1, #3, and #4, and then this package looks good to me :-) Thank you, Connor ------- rpmlint ------- rust-vmm-sys-util+default-devel.noarch: W: invalid-url URL: https://crates.io/crates/vmm-sys-util HTTP Error 404: Not Found rust-vmm-sys-util+default-devel.noarch: W: no-documentation rust-vmm-sys-util+serde-devel.noarch: W: spelling-error %description -l en_US serde -> sere, serge, serve rust-vmm-sys-util+serde-devel.noarch: W: invalid-url URL: https://crates.io/crates/vmm-sys-util HTTP Error 404: Not Found rust-vmm-sys-util+serde-devel.noarch: W: no-documentation rust-vmm-sys-util+serde_derive-devel.noarch: W: spelling-error %description -l en_US serde -> sere, serge, serve rust-vmm-sys-util+serde_derive-devel.noarch: W: invalid-url URL: https://crates.io/crates/vmm-sys-util HTTP Error 404: Not Found rust-vmm-sys-util+serde_derive-devel.noarch: W: no-documentation rust-vmm-sys-util-devel.noarch: W: invalid-url URL: https://crates.io/crates/vmm-sys-util HTTP Error 404: Not Found rust-vmm-sys-util-devel.noarch: W: hidden-file-or-dir /usr/share/cargo/registry/vmm-sys-util-0.8.0/.cargo-checksum.json rust-vmm-sys-util+with-serde-devel.noarch: W: invalid-url URL: https://crates.io/crates/vmm-sys-util HTTP Error 404: Not Found rust-vmm-sys-util+with-serde-devel.noarch: W: no-documentation rust-vmm-sys-util.src: W: invalid-url URL: https://crates.io/crates/vmm-sys-util HTTP Error 404: Not Found 6 packages and 0 specfiles checked; 0 errors, 13 warnings. --- I think the rpmlint output is fine, so no changes required here: - The link is fine if anyone actually clicks on it - 'serde' is not a real word, but Rust people know what it is - hidden-file-or-dir appears in lots of Rust crates, so I think it's fine - I think the documentation warning is in reference to man-pages or something, but this is just a devel library -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
