https://bugzilla.redhat.com/show_bug.cgi?id=1937455 --- Comment #4 from Richard W.M. Jones <rjones@xxxxxxxxxx> --- So a first look at the package and the emacs packaging guidelines (https://docs.fedoraproject.org/en-US/packaging-guidelines/Emacs/) Name looks good. xemacs is dead anyway these days. Has a subpackage called "emacs-foo" (emacs-caml-mode) - good. Lisp files in %{_emacs_sitelispdir}/caml-mode - good. Startup file in %{_emacs_sitestartdir} - good. Doesn't need a emacs-common-* subpackage - good. It's a bit unclear, but it seems like it could be missing this? Requires: emacs-filesystem >= %{_emacs_version} However the guidelines themselves seem to conflict, because the example only suggests using Requires: emacs(bin) >= %{_emacs_version} (which this package does - good). So maybe this is not a problem. Does BR emacs - good. Does bytecompilation using the suggested macros - good. BuildArch: noarch - good. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
