https://bugzilla.redhat.com/show_bug.cgi?id=1942114 --- Comment #5 from Jerry James <loganjerry@xxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - Package installs properly. Note: Installation errors (see attachment) See: https://docs.fedoraproject.org/en-US/packaging-guidelines/ This is the installation error: Error: Problem: conflicting requests - nothing provides libguestfs-dib >= 1:1.45.2-1 needed by virt-dib-1.45.2-1.fc35.x86_64 (try to add '--skip-broken' to skip uninstallable packages or '--nobest' to use not only best candidate packages) - Are these configure failures of concern? checking for OCaml findlib package oUnit... not found ... --- Checking for Perl --- checking for perl... perl checking for Pod::Man... yes checking for Pod::Simple... yes checking for Test::More... no checking for Module::Build... no configure: WARNING: some Perl modules required to compile or test the Perl bindings are missing checking for Pod::Usage... yes checking for Getopt::Long... yes checking for Locale::TextDomain... no checking for Win::Hivex... yes checking for Win::Hivex::Regedit... yes --- Checking for other libraries --- configure: WARNING: some Perl modules required to compile the Perl virt-* tools are missing - Some files carry the old FSF address on Mass Ave.: check-mli.sh, config.sh.in, ocaml-dep.sh.in, ocaml-link.sh.in ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: License file installed when any subpackage combination is installed. [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /etc/virt-builder(libguestfs- tools-c), /usr/share/bash-completion/completions(toolbox, swayidle, cobbler, golang-github-tdewolff-minify, exercism, tio, nbdkit-bash- completion, ModemManager, exa, devscripts, minipro, opensc, hyperfine, gpaste, flameshot, python3-pip, yadifa-tools, mt-st, datamash, rpmdevtools, coccinelle-bash-completion, chocolate-doom, zypper, rpmlint, bubblewrap, dconf-editor, devscripts-checkbashisms, driverctl, jo, unar, ffsend, git-delta, buildah, fd-find, ethtool, pbuilder, libqmi, rpmspectool, lxi-tools, calf, bodhi-client, fedpkg, python-django-bash-completion, firewalld, mercurial, firejail, swaylock, skim, bash-completion, cowsay, docopt, libappstream-glib, beaker-client, cmake-data, flatpak, libnbd-bash-completion, subversion, kmod, eg, git-core, fedmod, hstr, wlogout, darcs, falkon, ndctl, libguestfs-bash-completion, clevis, licensecheck, yadifa, stress-ng, monotone, playerctl, python3-catkin_tools, clufter-cli, gammu, xss-lock, GMT-common, sway, zeitgeist, ldc, git-annex, calibre, maven, rtags, pdfgrep, skopeo, rubygem-ronn-ng, source-highlight, docker-compose, dnf, lightdm, vagrant, breezy, lastpass-cli, dotnet- host, glib2, lxc, ripgrep, tig, nnn, libmbim, nordugrid-arc-client, etckeeper, restic, mtr, filesystem, nitrokey-app, zola, task, pipx, smc-tools, stratis-cli, awscli, cpu-x, kompose, tracker, tealdeer, packit, alacritty, reprepro, python3-trezor) These are fine. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: The spec file handles locales properly. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [!]: Requires correct, justified where necessary. virt-dib needs libguestfs-dib; see above [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 71680 bytes in 9 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Uses parallel make %{?_smp_mflags} macro. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Rpmlint is run on all installed packages. Note: Mock build failed See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_use_rpmlint [!]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 1280000 bytes in /usr/share [x]: Package should not use obsolete m4 macros [x]: Spec file according to URL is the same as in SRPM. Installation errors ------------------- INFO: mock.py version 2.9 starting (python version = 3.9.2, NVR = mock-2.9-1.fc33)... Start: init plugins INFO: selinux enabled Finish: init plugins INFO: Signal handler active Start: run Start: chroot init INFO: calling preinit hooks INFO: enabled root cache INFO: enabled package manager cache Start: cleaning package manager metadata Finish: cleaning package manager metadata INFO: enabled HW Info plugin Mock Version: 2.9 INFO: Mock Version: 2.9 Finish: chroot init INFO: installing package(s): /home/jamesjer/1942114-guestfs-tools/results/guestfs-tools-bash-completion-1.45.2-1.fc35.noarch.rpm /home/jamesjer/1942114-guestfs-tools/results/virt-win-reg-1.45.2-1.fc35.noarch.rpm /home/jamesjer/1942114-guestfs-tools/results/guestfs-tools-1.45.2-1.fc35.x86_64.rpm /home/jamesjer/1942114-guestfs-tools/results/virt-dib-1.45.2-1.fc35.x86_64.rpm /home/jamesjer/1942114-guestfs-tools/results/guestfs-tools-debugsource-1.45.2-1.fc35.x86_64.rpm /home/jamesjer/1942114-guestfs-tools/results/guestfs-tools-man-pages-uk-1.45.2-1.fc35.noarch.rpm /home/jamesjer/1942114-guestfs-tools/results/guestfs-tools-man-pages-ja-1.45.2-1.fc35.noarch.rpm /home/jamesjer/1942114-guestfs-tools/results/guestfs-tools-debuginfo-1.45.2-1.fc35.x86_64.rpm ERROR: Command failed: # /usr/bin/dnf --installroot /var/lib/mock/fedora-rawhide-x86_64/root/ --releasever 35 --setopt=deltarpm=False --allowerasing --disableplugin=local --disableplugin=spacewalk install /home/jamesjer/1942114-guestfs-tools/results/guestfs-tools-bash-completion-1.45.2-1.fc35.noarch.rpm /home/jamesjer/1942114-guestfs-tools/results/virt-win-reg-1.45.2-1.fc35.noarch.rpm /home/jamesjer/1942114-guestfs-tools/results/guestfs-tools-1.45.2-1.fc35.x86_64.rpm /home/jamesjer/1942114-guestfs-tools/results/virt-dib-1.45.2-1.fc35.x86_64.rpm /home/jamesjer/1942114-guestfs-tools/results/guestfs-tools-debugsource-1.45.2-1.fc35.x86_64.rpm /home/jamesjer/1942114-guestfs-tools/results/guestfs-tools-man-pages-uk-1.45.2-1.fc35.noarch.rpm /home/jamesjer/1942114-guestfs-tools/results/guestfs-tools-man-pages-ja-1.45.2-1.fc35.noarch.rpm /home/jamesjer/1942114-guestfs-tools/results/guestfs-tools-debuginfo-1.45.2-1.fc35.x86_64.rpm --setopt=tsflags=nocontexts Rpmlint ------- Checking: guestfs-tools-1.45.2-1.fc35.x86_64.rpm virt-win-reg-1.45.2-1.fc35.noarch.rpm virt-dib-1.45.2-1.fc35.x86_64.rpm guestfs-tools-bash-completion-1.45.2-1.fc35.noarch.rpm guestfs-tools-man-pages-ja-1.45.2-1.fc35.noarch.rpm guestfs-tools-man-pages-uk-1.45.2-1.fc35.noarch.rpm guestfs-tools-debuginfo-1.45.2-1.fc35.x86_64.rpm guestfs-tools-debugsource-1.45.2-1.fc35.x86_64.rpm guestfs-tools-1.45.2-1.fc35.src.rpm guestfs-tools.x86_64: W: spelling-error %description -l en_US virt -> dirt, girt, vi rt guestfs-tools.x86_64: W: spelling-error %description -l en_US df -> sf, ff, dd guestfs-tools.x86_64: W: spelling-error %description -l en_US Virt -> Dirt, Girt, Vi rt guestfs-tools.x86_64: W: spelling-error %description -l en_US doesn -> does, does n guestfs-tools.x86_64: W: spelling-error %description -l en_US initrd -> trinity guestfs-tools.x86_64: W: spelling-error %description -l en_US virtualized -> ritualized, visualized, actualized guestfs-tools.x86_64: W: spelling-error %description -l en_US fs -> sf, gs, fa guestfs-tools.x86_64: W: spelling-error %description -l en_US resize -> reside, re size, re-size guestfs-tools.x86_64: W: spelling-error %description -l en_US sparsify -> sparsity, sparse guestfs-tools.x86_64: W: spelling-error %description -l en_US sysprep -> spree guestfs-tools.x86_64: W: spelling-error %description -l en_US unconfigure -> reconfigure, configure, reconfiguration guestfs-tools.x86_64: E: missing-call-to-chdir-with-chroot /usr/bin/virt-builder guestfs-tools.x86_64: E: missing-call-to-chdir-with-chroot /usr/bin/virt-builder-repository guestfs-tools.x86_64: E: missing-call-to-chdir-with-chroot /usr/bin/virt-customize guestfs-tools.x86_64: E: missing-call-to-chdir-with-chroot /usr/bin/virt-get-kernel guestfs-tools.x86_64: E: missing-call-to-chdir-with-chroot /usr/bin/virt-resize guestfs-tools.x86_64: E: missing-call-to-chdir-with-chroot /usr/bin/virt-sparsify guestfs-tools.x86_64: E: missing-call-to-chdir-with-chroot /usr/bin/virt-sysprep virt-dib.x86_64: W: spelling-error Summary(en_US) diskimage -> disk image, disk-image, disparage virt-dib.x86_64: W: spelling-error %description -l en_US diskimage -> disk image, disk-image, disparage virt-dib.x86_64: E: missing-call-to-chdir-with-chroot /usr/bin/virt-dib guestfs-tools-bash-completion.noarch: W: spelling-error %description -l en_US virt -> dirt, girt, vi rt guestfs-tools-bash-completion.noarch: W: no-documentation guestfs-tools.src: W: spelling-error %description -l en_US virt -> dirt, girt, vi rt guestfs-tools.src: W: spelling-error %description -l en_US df -> sf, ff, dd guestfs-tools.src: W: spelling-error %description -l en_US Virt -> Dirt, Girt, Vi rt guestfs-tools.src: W: spelling-error %description -l en_US doesn -> does, does n guestfs-tools.src: W: spelling-error %description -l en_US initrd -> trinity guestfs-tools.src: W: spelling-error %description -l en_US virtualized -> ritualized, visualized, actualized guestfs-tools.src: W: spelling-error %description -l en_US fs -> sf, gs, fa guestfs-tools.src: W: spelling-error %description -l en_US resize -> reside, re size, re-size guestfs-tools.src: W: spelling-error %description -l en_US sparsify -> sparsity, sparse guestfs-tools.src: W: spelling-error %description -l en_US sysprep -> spree guestfs-tools.src: W: spelling-error %description -l en_US unconfigure -> reconfigure, configure, reconfiguration guestfs-tools.src: W: strange-permission guestfs-tools-1.45.2.tar.gz.sig 775 9 packages and 0 specfiles checked; 8 errors, 27 warnings. I manually installed everything except virt-dib and ran rpmlint, with these results: guestfs-tools.x86_64: W: spelling-error %description -l en_US virt -> dirt, girt, vi rt guestfs-tools.x86_64: W: spelling-error %description -l en_US df -> sf, ff, dd guestfs-tools.x86_64: W: spelling-error %description -l en_US Virt -> Dirt, Girt, Vi rt guestfs-tools.x86_64: W: spelling-error %description -l en_US doesn -> does, does n guestfs-tools.x86_64: W: spelling-error %description -l en_US initrd -> trinity guestfs-tools.x86_64: W: spelling-error %description -l en_US virtualized -> ritualized, visualized, actualized guestfs-tools.x86_64: W: spelling-error %description -l en_US fs -> sf, gs, fa guestfs-tools.x86_64: W: spelling-error %description -l en_US resize -> reside, re size, re-size guestfs-tools.x86_64: W: spelling-error %description -l en_US sparsify -> sparsity, sparse guestfs-tools.x86_64: W: spelling-error %description -l en_US sysprep -> spree guestfs-tools.x86_64: W: spelling-error %description -l en_US unconfigure -> reconfigure, configure, reconfiguration guestfs-tools.x86_64: E: missing-call-to-chdir-with-chroot /usr/bin/virt-builder guestfs-tools.x86_64: E: missing-call-to-chdir-with-chroot /usr/bin/virt-builder-repository guestfs-tools.x86_64: E: missing-call-to-chdir-with-chroot /usr/bin/virt-customize guestfs-tools.x86_64: E: missing-call-to-chdir-with-chroot /usr/bin/virt-get-kernel guestfs-tools.x86_64: E: missing-call-to-chdir-with-chroot /usr/bin/virt-resize guestfs-tools.x86_64: E: missing-call-to-chdir-with-chroot /usr/bin/virt-sparsify guestfs-tools.x86_64: E: missing-call-to-chdir-with-chroot /usr/bin/virt-sysprep guestfs-tools-bash-completion.noarch: W: spelling-error %description -l en_US virt -> dirt, girt, vi rt guestfs-tools-bash-completion.noarch: W: no-documentation 7 packages and 0 specfiles checked; 7 errors, 13 warnings. Source checksums ---------------- http://download.libguestfs.org/guestfs-tools/1.45-development/guestfs-tools-1.45.2.tar.gz.sig : CHECKSUM(SHA256) this package : ef33b5cde281a73f81db74de78d2cd05e1e2636df62cd4936c1691906ca0d3ed CHECKSUM(SHA256) upstream package : ef33b5cde281a73f81db74de78d2cd05e1e2636df62cd4936c1691906ca0d3ed http://download.libguestfs.org/guestfs-tools/1.45-development/guestfs-tools-1.45.2.tar.gz : CHECKSUM(SHA256) this package : ab7531f9b2506878406ace50d609c91c4ee8b35cfdf6c2e145119bbeb9ab2006 CHECKSUM(SHA256) upstream package : ab7531f9b2506878406ace50d609c91c4ee8b35cfdf6c2e145119bbeb9ab2006 Requires -------- guestfs-tools (rpmlib, GLIBC filtered): /usr/bin/qemu-img config(guestfs-tools) curl gnupg2 libc.so.6()(64bit) libcrypt.so.2()(64bit) libcrypt.so.2(XCRYPT_2.0)(64bit) libdl.so.2()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libguestfs.so.0()(64bit) libjansson.so.4()(64bit) liblzma.so.5()(64bit) liblzma.so.5(XZ_5.0)(64bit) libm.so.6()(64bit) libpcre2-8.so.0()(64bit) libpthread.so.0()(64bit) libtinfo.so.6()(64bit) libvirt.so.0()(64bit) libvirt.so.0(LIBVIRT_0.0.3)(64bit) libvirt.so.0(LIBVIRT_0.1.0)(64bit) libvirt.so.0(LIBVIRT_0.1.1)(64bit) libvirt.so.0(LIBVIRT_0.1.5)(64bit) libvirt.so.0(LIBVIRT_0.4.0)(64bit) libxml2.so.2()(64bit) libxml2.so.2(LIBXML2_2.4.30)(64bit) libxml2.so.2(LIBXML2_2.6.0)(64bit) libxml2.so.2(LIBXML2_2.6.5)(64bit) libxml2.so.2(LIBXML2_2.6.8)(64bit) rtld(GNU_HASH) xz virt-win-reg (rpmlib, GLIBC filtered): /usr/bin/perl virt-dib (rpmlib, GLIBC filtered): libc.so.6()(64bit) libdl.so.2()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libguestfs-dib libguestfs.so.0()(64bit) libm.so.6()(64bit) libpcre2-8.so.0()(64bit) libpthread.so.0()(64bit) rtld(GNU_HASH) guestfs-tools-bash-completion (rpmlib, GLIBC filtered): bash-completion guestfs-tools guestfs-tools-man-pages-ja (rpmlib, GLIBC filtered): guestfs-tools guestfs-tools-man-pages-uk (rpmlib, GLIBC filtered): guestfs-tools guestfs-tools-debuginfo (rpmlib, GLIBC filtered): guestfs-tools-debugsource (rpmlib, GLIBC filtered): Provides -------- guestfs-tools: config(guestfs-tools) guestfs-tools guestfs-tools(x86-64) libguestfs-tools-c virt-win-reg: libguestfs-tools virt-win-reg virt-dib: virt-dib virt-dib(x86-64) guestfs-tools-bash-completion: guestfs-tools-bash-completion guestfs-tools-man-pages-ja: guestfs-tools-man-pages-ja guestfs-tools-man-pages-uk: guestfs-tools-man-pages-uk guestfs-tools-debuginfo: debuginfo(build-id) guestfs-tools-debuginfo guestfs-tools-debuginfo(x86-64) guestfs-tools-debugsource: guestfs-tools-debugsource guestfs-tools-debugsource(x86-64) Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 1942114 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic, C/C++ Disabled plugins: Perl, Ocaml, fonts, R, Ruby, Java, SugarActivity, PHP, Haskell, Python Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
