Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mumble - low-latency, high quality voice chat software https://bugzilla.redhat.com/show_bug.cgi?id=294001 ------- Additional Comments From michel.sylvan@xxxxxxxxx 2007-11-15 12:49 EST ------- - the buildroot clean-up in %install should happen _before_ all the other steps, not after (otherwise you'll never get anything installed) - for desktop-file-install, not sure you can add X-Red-Hat-Base . It's not a core package - You mispelled %{_includedir} and %{_libdir} in %files devel - Last thing: the fields at the top of the file (name, version, etc.) are still tabbed a bit too much. Could you perhaps reduce the tabulation a bit? Looks almost ready. Is there any way to test mumble with only one machine? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review