Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: perl-DBI https://bugzilla.redhat.com/show_bug.cgi?id=226253 panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From panemade@xxxxxxxxx 2007-11-15 00:51 EST ------- Review: + package builds in mock (development i386). + rpmlint is silent for SRPM but NOT for RPM. perl-DBI.i386: W: devel-file-in-non-devel-package /usr/lib/perl5/vendor_perl/5.8.8/i386-linux-thread-multi/auto/DBI/dbixs_rev.h perl-DBI.i386: W: devel-file-in-non-devel-package /usr/lib/perl5/vendor_perl/5.8.8/i386-linux-thread-multi/auto/DBI/dbivport.h perl-DBI.i386: W: devel-file-in-non-devel-package /usr/lib/perl5/vendor_perl/5.8.8/i386-linux-thread-multi/auto/DBI/dbd_xsh.h perl-DBI.i386: W: devel-file-in-non-devel-package /usr/lib/perl5/vendor_perl/5.8.8/i386-linux-thread-multi/auto/DBI/dbipport.h perl-DBI.i386: W: devel-file-in-non-devel-package /usr/lib/perl5/vendor_perl/5.8.8/i386-linux-thread-multi/auto/DBI/Driver_xst.h perl-DBI.i386: W: devel-file-in-non-devel-package /usr/lib/perl5/vendor_perl/5.8.8/i386-linux-thread-multi/auto/DBI/DBIXS.h perl-DBI.i386: W: devel-file-in-non-devel-package /usr/lib/perl5/vendor_perl/5.8.8/i386-linux-thread-multi/auto/DBI/dbi_sql.h ==> Ok to accept. + source files match upstream url d80677bd8113ec8cb0438b8703f3c418 DBI-1.601.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test outputs All tests successful, 28 tests and 379 subtests skipped. 2007-11-15 10:41:06,624 - util.py:218:DEBUG: Files=125, Tests=5842, 131 wallclock secs (54.22 cusr + 6.98 csys = 61.20 CPU) + Package perl-DBI-1.601-1.fc9 -> Provides: DBI.so perl(Bundle::DBI) = 8695 perl(DBD::DBM) = 0.03 perl(DBD::DBM::Statement) perl(DBD::DBM::Table) perl(DBD::DBM::db) perl(DBD::DBM::dr) perl(DBD::DBM::st) perl(DBD::ExampleP) = 10007 perl(DBD::File) = 0.35 perl(DBD::File::Statement) perl(DBD::File::Table) perl(DBD::File::db) perl(DBD::File::dr) perl(DBD::File::st) perl(DBD::Gofer) = 10103 perl(DBD::Gofer::Policy::Base) = 10087 perl(DBD::Gofer::Policy::classic) = 10087 perl(DBD::Gofer::Policy::pedantic) = 10087 perl(DBD::Gofer::Policy::rush) = 10087 perl(DBD::Gofer::Transport::Base) = 10088 perl(DBD::Gofer::Transport::null) = 10087 perl(DBD::Gofer::Transport::pipeone) = 10087 perl(DBD::Gofer::Transport::stream) = 10087 perl(DBD::NullP) = 9215 perl(DBD::Proxy) = 0.2004 perl(DBD::Proxy::db) perl(DBD::Proxy::dr) perl(DBD::Proxy::st) perl(DBD::Sponge) = 10002 perl(DBDI) perl(DBI) perl(DBI::Const::GetInfo::ANSI) = 8696 perl(DBI::Const::GetInfo::ODBC) = 8696 perl(DBI::Const::GetInfoReturn) = 8696 perl(DBI::Const::GetInfoType) = 8696 perl(DBI::DBD) = 12. perl(DBI::DBD::Metadata) = 8696 perl(DBI::FAQ) = 9530 perl(DBI::Gofer::Execute) = 10087 perl(DBI::Gofer::Request) = 10087 perl(DBI::Gofer::Response) = 10087 perl(DBI::Gofer::Serializer::Base) = 9949 perl(DBI::Gofer::Serializer::DataDumper) = 9949 perl(DBI::Gofer::Serializer::Storable) = 9949 perl(DBI::Gofer::Transport::Base) = 10087 perl(DBI::Gofer::Transport::pipeone) = 10087 perl(DBI::Gofer::Transport::stream) = 10087 perl(DBI::Profile) = 9833 perl(DBI::ProfileData) = 10007 perl(DBI::ProfileDumper) = 9894 perl(DBI::ProfileDumper::Apache) = 9618 perl(DBI::ProfileSubs) = 9395 perl(DBI::ProxyServer) = 0.3005 perl(DBI::ProxyServer::db) perl(DBI::ProxyServer::dr) perl(DBI::ProxyServer::st) perl(DBI::SQL::Nano) = 9744 perl(DBI::SQL::Nano::Statement_) perl(DBI::SQL::Nano::Table_) perl(DBI::Util::CacheMemory) = 10086 perl(DBI::Util::_accessor) = 9478 perl(DBI::common) Requires: /usr/bin/perl libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.3) libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.4) perl >= 0:5.004 perl >= 0:5.005_03 perl >= 0:5.006_00 perl(:MODULE_COMPAT_5.8.8) perl(Carp) perl(Config) perl(Cwd) perl(DBI) perl(DBI::Const::GetInfo::ANSI) perl(DBI::Const::GetInfo::ODBC) perl(DBI::Const::GetInfoType) perl(DBI::Gofer::Execute) perl(DBI::Gofer::Request) perl(DBI::Gofer::Response) perl(DBI::Gofer::Serializer::DataDumper) perl(DBI::Gofer::Serializer::Storable) perl(DBI::Profile) perl(DBI::ProfileData) perl(DBI::ProfileDumper) perl(DBI::ProxyServer) perl(DBI::SQL::Nano) perl(Data::Dumper) perl(DynaLoader) perl(Exporter) perl(Fcntl) perl(File::Spec) perl(Getopt::Long) perl(IO::File) perl(IO::Select) perl(IPC::Open3) perl(Storable) perl(Symbol) perl(UNIVERSAL) perl(base) perl(constant) perl(strict) perl(utf8) perl(vars) perl(warnings) rtld(GNU_HASH) APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review