https://bugzilla.redhat.com/show_bug.cgi?id=1939875 --- Comment #3 from Otto Urpelainen <oturpe@xxxxxx> --- A couple of findings more: 3. When I try to build from srpm in Koji, I get the following error: /bin/sh: line 1: xxd: command not found Build command was this: $ koji build --scratch f35 litehtml-0.5-1.gitdb7f59d.fc35.src.rpm and logs are at https://koji.fedoraproject.org/koji/taskinfo?taskID=63994712 Is BuildRequires: vim-common missing? $ dnf repoquery --whatprovides /usr/bin/xxd vim-common-2:8.2.1770-1.fc33.x86_64 vim-common-2:8.2.2607-1.fc33.x86_64 (Strange by the way, I do not understand how vim is involved with this.) 4. I agree with Elliott about (un)bundling gumbo. Upstream should be contacted about this, too. Reference: https://docs.fedoraproject.org/en-US/packaging-guidelines/#bundling 5. I see some tests available upstream, but there is no %check in the spec file. The tests should be run if possible. Reference: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_test_suites, also discussion of %ctest macro in https://docs.fedoraproject.org/en-US/packaging-guidelines/CMake/ may be relevant -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
