https://bugzilla.redhat.com/show_bug.cgi?id=1936059 --- Comment #3 from Jonny Heggheim <hegjon@xxxxxxxxx> --- Thanks for the review. (In reply to Robert-André Mauchin 🐧 from comment #2) > - Starting F33, this is not needed anymore: > > %{?python_provide:%python_provide python3-%{srcname}} Thanks, removed, great to know. > - Can't you package it to run the tests: > > # Missing dependency to allpairspy I will create another review for allpairspy, will enable tests once allpairspy have added. > - Please remove the executable bits from these files and send a patch > upstream to fix it: > > python3-pathvalidate.noarch: W: spurious-executable-perm > /usr/share/doc/python3-pathvalidate/README.rst > python3-pathvalidate.noarch: E: script-without-shebang > /usr/share/licenses/python3-pathvalidate/LICENSE > > Package approved. Please fix the aforementioned issues before import. Changed file permission in spec file to 644 and created https://github.com/thombashi/pathvalidate/issues/17 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
