[Bug 1928969] Review Request: chatty - mobile libpurple messaging client

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1928969



--- Comment #7 from Kevin Fenzi <kevin@xxxxxxxxx> ---
ok. After messing with this a bunch yesterday, I see where I was wrong. :) 
You do have to copy this private lib and modify the meson config to build
against it.
However, currently you are shipping it in libdir for everything else to see and
use, and it could well get out of date, if say pidgin is updated but chatty
isn't yet. 

So, I can offer the following (sadly a bit complex) change: 

Exclude requriing libjabber from the chatty rpm. 
(If we don't do this, it will expect that library to be provided by either
itself or libpurple, but we don't want to provide it here (because other things
might try and use it and it's not ours) and libpurple doesn't want to provide
it as it's a private library.

> %global __requires_exclude ^libjabber\\.so.*$

For build, the existing patch and copying to /tmp works.

In install add a ld.so.conf.d config to have it look in the purple-2 private
dir for libs:

> mkdir -p %{buildroot}/%{_sysconfdir}/ld.so.conf.d
> echo "%{_libdir}/chatty" > %{buildroot}/%{_sysconfdir}/ld.so.conf.d/chatty.conf

Add the conf to files:

> %{_sysconfdir}/ld.so.conf.d/chatty.conf

so, this way, chatty doesn't actually provide or have the library, it's still
in libpurple, it just looks there when installed. 
I tested this here and it seemed to all work, but worth testing again in case I
missed something. 
It's still not ideal, but I think it's better than shipping the pidgin private
lib in chatty.

Thoughts?


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux