Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libgnomedbmm - C++ interface for libgnomedb https://bugzilla.redhat.com/show_bug.cgi?id=380871 panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From panemade@xxxxxxxxx 2007-11-14 23:07 EST ------- Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream url 26b43d48b872f250e96ee6937bdee5a1 libgnomedbmm-2.9.5.tar.bz2 + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + BuildRequires are proper. + Compiler flags used correctly. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no static libraries. + libgnomedbmm-3.0.pcfile present. + -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + ldconfig scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Package libgnomedbmm-2.9.5-2.fc9 -> Provides: libgnomedbmm-3.0.so.1 Requires: libart_lgpl_2.so.2 libatk-1.0.so.0 libatkmm-1.6.so.1 libc.so.6 libc.so.6(GLIBC_2.1.3) libcairo.so.2 libcairomm-1.0.so.1 libdl.so.2 libgcc_s.so.1 libgcc_s.so.1(GCC_3.0) libgda-3.0.so.3 libgda-report-3.0.so.3 libgdamm-3.0.so.8 libgdasql-3.0.so.3 libgdk-x11-2.0.so.0 libgdk_pixbuf-2.0.so.0 libgdkmm-2.4.so.1 libglade-2.0.so.0 libglib-2.0.so.0 libglibmm-2.4.so.1 libgmodule-2.0.so.0 libgnomecanvas-2.so.0 libgnomedb-3.0.so.4 libgnomedb_extra-3.0.so.4 libgnomedb_graph-3.0.so.4 libgnomedbmm-3.0.so.1 libgobject-2.0.so.0 libgthread-2.0.so.0 libgtk-x11-2.0.so.0 libgtkmm-2.4.so.1 libm.so.6 libpango-1.0.so.0 libpangocairo-1.0.so.0 libpangomm-1.4.so.1 librt.so.1 libsigc-2.0.so.0 libstdc++.so.6 libstdc++.so.6(CXXABI_1.3) libstdc++.so.6(GLIBCXX_3.4) libxml2.so.2 rtld(GNU_HASH) + Package libgnomedbmm-devel-2.9.5-2.fc9 -> Requires: gtkmm24-devel libgdamm-devel libgnomedb-devel libgnomedbmm = 2.9.5-2.fc9 libgnomedbmm-3.0.so.1 pkgconfig + Not a GUI App. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review