https://bugzilla.redhat.com/show_bug.cgi?id=1939271 --- Comment #3 from Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> --- (In reply to Mikel Olasagasti Uranga from comment #2) > thanks for reviewing! > > I think I addressed all the issues: > > Spec URL: https://mikel.olasagasti.info/tmp/fedora/poke.spec > SRPM URL: https://mikel.olasagasti.info/tmp/fedora/poke-1.0-2.fc33.src.rpm > > > - Info page are handled by %transfiletrigger, this is not necessary anymore: > > I took this from > https://docs.fedoraproject.org/en-US/quick-docs/create-hello-world-rpm/ that > should be updated. Should I open a BZ for that? Yes this is obsolete I believe. Try filing a bug here: https://pagure.io/packaging-committee/issues - the devel package should requires the libs package not the main package: %package devel Summary: Development files for %{name} Requires: %{name}-libs%{?_isa} = %{version}-%{release} %description devel The %{name}-devel package contains libraries and header files for developing applications that use %{name}. - the libs subpackage should probably be able to be installed independently from the main package: Requires: %{name}%{?_isa} = %{version}-%{release} - This should contain the license too %files libs %license COPYING %{_libdir}/libpoke.so.0* - The data subpackage should probably depend on the main package as it is useless without it: %package data Summary: Data files for %{name} BuildArch: noarch Requires: %{name}%{?_isa} = %{version}-%{release} %description data Data files for %{name}. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
