https://bugzilla.redhat.com/show_bug.cgi?id=1930386 Ankur Sinha (FranciscoD) <sanjay.ankur@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+ --- Comment #4 from Ankur Sinha (FranciscoD) <sanjay.ankur@xxxxxxxxx> --- Looks good. One or two nitpicks but you can fix those before importing XXXX APPROVED XXXX - please correct the cleanup command as per the R guidelines. It should be: test -d %{packname}/src && (cd %{packname}/src; rm -f *.o *.so) The current command also removes the *c and *h files, but they should not be removed since they are used by the debug packages. https://docs.fedoraproject.org/en-US/packaging-guidelines/R/#_cleaning_the_r_directory_of_binaries - Since the CRAN archive does not include the license, you can skip it. In general, if upstream does include a license file in the upstream sources (Git) even if they don't include it in the release tars, we can include just the license file from the upstream SCM like this: Source1: https://github.com/mhahsler/arules/raw/master/LICENSE In %prep after %setup: cp %{SOURCE1} . This just copies the file to the directory of the uncompressed tar and we can then list the file as we would normally list other files: %license LICENSE - I think when you list %{_libdir}/R/library/%{packname}/libs you're already including all the files in the directory, so this shouldn't be required: %{_libdir}/R/library/%{packname}/libs/%{packname}.so If you do want to list the files separately, then the directory listing will be: %dir %{_libdir}/R/library/%{packname}/libs and then all files will need to be listed (using a wildcard if necessary). Cheers, Ankur -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
