Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mumble - low-latency, high quality voice chat software https://bugzilla.redhat.com/show_bug.cgi?id=294001 ------- Additional Comments From michel.sylvan@xxxxxxxxx 2007-11-14 21:21 EST ------- * service startup: You might want to edit murmur.init: # chkconfig: 35 90 12 the 35 in that line specifies that it will be started at runlevel 3 and 5, and 'man chkconfig' says to put a - in place of the runlevels if you don't want it started. * Groups: The Group needs to be changed -- see /usr/share/doc/rpm-4.4.2.2/GROUPS. Looking at pulseaudio's use of groups might be instructive as it does roughly the same thing, so: mumble : Applications/Multimedia -server : System Environment/Daemons -devel : Development/Libraries (any chance the original spec was written for Mandriva?) Also, this is probably more convention than requirement, but we don't normally use macros for things like %__install , %__ln_s and %__mkdir. * %install section needs 'rm -rf %{buildroot}' as well * use spaces or tabs for indentation, but do not mix both (probably use less whitespace as well; some lines are longer than 80 characters) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review