https://bugzilla.redhat.com/show_bug.cgi?id=1928272 code@xxxxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(zebob.m@xxxxxxxxx | |) --- Comment #8 from code@xxxxxxxxxxxxxxxxxx --- > - Why are node_modules symbolic links to node_modules_prod? Why not put them directly at node_modules? This is taken directly from the template at https://docs.fedoraproject.org/en-US/packaging-guidelines/Node.js/#_using_tarballs_for_bundling. I do not know the original rationale. ----- > - Why do you convert the Markdown files to HTML? It seemed like it would be useful to have them available in a browser-friendly format. In retrospect, this is probably excessive for a couple of simple files. I have removed the conversion: New spec URL: https://music.fedorapeople.org/fx-20.0.2-2/fx.spec New SRPM URL: https://music.fedorapeople.org/fx-20.0.2-2/fx-20.0.2-2.fc33.src.rpm ----- > [!]: License field in the package spec file matches the actual license. > Note: Checking patched sources after %prep for licenses. Licenses > found: "Unknown or generated", "Expat License", "*No copyright* Expat > License", "SIL Open Font License 1.1", "SIL Open Font License 1.1 GNU > General Public License v2.0 or later". 138 files have unknown license. > Detailed output of licensecheck in > /home/bob/packaging/review/fx/review-fx/licensecheck.txt Are you sure? node_modules_prod/@medv/blessed/usr/fonts/README says: > The files configure, configure.help, bdftopsf.pl and ucstoany.pl are > distributed under the GNU General Public License version 2.0 or (at your > choice) any later version. but these files are not present in the bundle. So with GPLv2+ out of the mix, I think all licenses are covered by “MIT and OFL”. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
