https://bugzilla.redhat.com/show_bug.cgi?id=1919295 Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@xxxxxxxxxxxxxxxxx |zebob.m@xxxxxxxxx Flags| |fedora-review? --- Comment #6 from Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> --- - Why are node_modules symbolic links to node_modules_prod? Why not put them directly at node_modules? - useless-provides: This package provides 2 times the same capacity. It should only provide it once. Apparently the bundled Provides are specified 2 times? - Dotfiles under node_modules are normal. No the various .travis.yml .eslintrc .npmignore .eslintignore etc. should not be shipped Use "find %{buildroot} -type f -name '.*' -delete" to find them and delete them - npm-name-cli.noarch: E: script-without-shebang /usr/lib/node_modules/npm-name-cli/node_modules_prod/org-regex/package.json npm-name-cli.noarch: E: script-without-shebang /usr/lib/node_modules/npm-name-cli/node_modules_prod/squatter/node_modules/@szmarczak/http-timer/package.jso npm-name-cli.noarch: E: script-without-shebang /usr/lib/node_modules/npm-name-cli/node_modules_prod/check-npm-dependents/node_modules/@szmarczak/http-timer/package.json npm-name-cli.noarch: E: script-without-shebang /usr/lib/node_modules/npm-name-cli/node_modules_prod/@types/normalize-package-data/package.json npm-name-cli.noarch: E: script-without-shebang /usr/lib/node_modules/npm-name-cli/node_modules_prod/cacheable-lookup/package.json Use "find %{buildroot} -name "package.json" -executable -type f -exec chmod 0644 '{}' \;" to search for them and remove the exec bits. - Remove various empty files shipped. See https://fedoraproject.org/wiki/Packaging_tricks#Zero_length_files find %{buildroot} -size 0 -delete Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "Expat License", "BSD 3-clause "New" or "Revised" License", "*No copyright* Expat License", "ISC License", "BSD 2-clause "Simplified" License", "Expat License [generated file]", "Apache License 2.0", "*No copyright* Apache License 2.0", "*No copyright* [generated file]". 1486 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/npm- name-cli/review-npm-name-cli/licensecheck.txt [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: npm-name-cli-3.0.0-2.fc35.noarch.rpm npm-name-cli-3.0.0-2.fc35.src.rpm npm-name-cli.noarch: E: useless-provides bundled(nodejs-ansi-styles) npm-name-cli.noarch: E: useless-provides bundled(nodejs-cacheable-request) npm-name-cli.noarch: E: useless-provides bundled(nodejs-chalk) npm-name-cli.noarch: E: useless-provides bundled(nodejs-color-convert) npm-name-cli.noarch: E: useless-provides bundled(nodejs-color-name) npm-name-cli.noarch: E: useless-provides bundled(nodejs-decompress-response) npm-name-cli.noarch: E: useless-provides bundled(nodejs-defer-to-connect) npm-name-cli.noarch: E: useless-provides bundled(nodejs-get-stream) npm-name-cli.noarch: E: useless-provides bundled(nodejs-got) npm-name-cli.noarch: E: useless-provides bundled(nodejs-has-flag) npm-name-cli.noarch: E: useless-provides bundled(nodejs-http-cache-semantics) npm-name-cli.noarch: E: useless-provides bundled(nodejs-json-buffer) npm-name-cli.noarch: E: useless-provides bundled(nodejs-keyv) npm-name-cli.noarch: E: useless-provides bundled(nodejs-lowercase-keys) npm-name-cli.noarch: E: useless-provides bundled(nodejs-map-obj) npm-name-cli.noarch: E: useless-provides bundled(nodejs-mimic-response) npm-name-cli.noarch: E: useless-provides bundled(nodejs-normalize-url) npm-name-cli.noarch: E: useless-provides bundled(nodejs-p-cancelable) npm-name-cli.noarch: E: useless-provides bundled(nodejs-p-map) npm-name-cli.noarch: E: useless-provides bundled(nodejs-p-timeout) npm-name-cli.noarch: E: useless-provides bundled(nodejs-registry-auth-token) npm-name-cli.noarch: E: useless-provides bundled(nodejs-registry-url) npm-name-cli.noarch: E: useless-provides bundled(nodejs-responselike) npm-name-cli.noarch: E: useless-provides bundled(nodejs-safe-buffer) npm-name-cli.noarch: E: useless-provides bundled(nodejs-supports-color) npm-name-cli.noarch: E: useless-provides bundled(nodejs-to-readable-stream) npm-name-cli.noarch: E: useless-provides bundled(nodejs-type-fest) npm-name-cli.noarch: W: only-non-binary-in-usr-lib npm-name-cli.noarch: W: hidden-file-or-dir /usr/lib/node_modules/npm-name-cli/node_modules/.bin npm-name-cli.noarch: W: hidden-file-or-dir /usr/lib/node_modules/npm-name-cli/node_modules_prod/.bin npm-name-cli.noarch: W: hidden-file-or-dir /usr/lib/node_modules/npm-name-cli/node_modules_prod/.bin npm-name-cli.noarch: W: hidden-file-or-dir /usr/lib/node_modules/npm-name-cli/node_modules_prod/@babel/highlight/node_modules/color-name/.eslintrc.json npm-name-cli.noarch: W: hidden-file-or-dir /usr/lib/node_modules/npm-name-cli/node_modules_prod/@babel/highlight/node_modules/color-name/.npmignore npm-name-cli.noarch: E: script-without-shebang /usr/lib/node_modules/npm-name-cli/node_modules_prod/@types/normalize-package-data/package.json npm-name-cli.noarch: W: hidden-file-or-dir /usr/lib/node_modules/npm-name-cli/node_modules_prod/builtins/.travis.yml npm-name-cli.noarch: E: script-without-shebang /usr/lib/node_modules/npm-name-cli/node_modules_prod/cacheable-lookup/package.json npm-name-cli.noarch: W: hidden-file-or-dir /usr/lib/node_modules/npm-name-cli/node_modules_prod/check-npm-dependents/.editorconfig npm-name-cli.noarch: W: hidden-file-or-dir /usr/lib/node_modules/npm-name-cli/node_modules_prod/check-npm-dependents/.eslintrc npm-name-cli.noarch: W: hidden-file-or-dir /usr/lib/node_modules/npm-name-cli/node_modules_prod/check-npm-dependents/.travis.yml npm-name-cli.noarch: E: script-without-shebang /usr/lib/node_modules/npm-name-cli/node_modules_prod/check-npm-dependents/node_modules/@szmarczak/http-timer/package.json npm-name-cli.noarch: W: hidden-file-or-dir /usr/lib/node_modules/npm-name-cli/node_modules_prod/check-npm-dependents/node_modules/json-buffer/.npmignore npm-name-cli.noarch: W: hidden-file-or-dir /usr/lib/node_modules/npm-name-cli/node_modules_prod/check-npm-dependents/node_modules/json-buffer/.travis.yml npm-name-cli.noarch: W: hidden-file-or-dir /usr/lib/node_modules/npm-name-cli/node_modules_prod/clone/.npmignore npm-name-cli.noarch: W: hidden-file-or-dir /usr/lib/node_modules/npm-name-cli/node_modules_prod/defaults/.npmignore npm-name-cli.noarch: W: hidden-file-or-dir /usr/lib/node_modules/npm-name-cli/node_modules_prod/from2/.travis.yml npm-name-cli.noarch: W: hidden-file-or-dir /usr/lib/node_modules/npm-name-cli/node_modules_prod/function-bind/.editorconfig npm-name-cli.noarch: W: hidden-file-or-dir /usr/lib/node_modules/npm-name-cli/node_modules_prod/function-bind/.eslintrc npm-name-cli.noarch: W: hidden-file-or-dir /usr/lib/node_modules/npm-name-cli/node_modules_prod/function-bind/.jscs.json npm-name-cli.noarch: W: hidden-file-or-dir /usr/lib/node_modules/npm-name-cli/node_modules_prod/function-bind/.npmignore npm-name-cli.noarch: W: hidden-file-or-dir /usr/lib/node_modules/npm-name-cli/node_modules_prod/function-bind/.travis.yml npm-name-cli.noarch: W: hidden-file-or-dir /usr/lib/node_modules/npm-name-cli/node_modules_prod/function-bind/test/.eslintrc npm-name-cli.noarch: W: hidden-file-or-dir /usr/lib/node_modules/npm-name-cli/node_modules_prod/has-symbol-support-x/.editorconfig npm-name-cli.noarch: W: hidden-file-or-dir /usr/lib/node_modules/npm-name-cli/node_modules_prod/has-symbol-support-x/.eslintignore npm-name-cli.noarch: W: hidden-file-or-dir /usr/lib/node_modules/npm-name-cli/node_modules_prod/has-symbol-support-x/.eslintrc.json npm-name-cli.noarch: W: hidden-file-or-dir /usr/lib/node_modules/npm-name-cli/node_modules_prod/has-symbol-support-x/.nvmrc npm-name-cli.noarch: W: hidden-file-or-dir /usr/lib/node_modules/npm-name-cli/node_modules_prod/has-symbol-support-x/.travis.yml npm-name-cli.noarch: W: hidden-file-or-dir /usr/lib/node_modules/npm-name-cli/node_modules_prod/has-symbol-support-x/.uglifyjsrc.json npm-name-cli.noarch: W: hidden-file-or-dir /usr/lib/node_modules/npm-name-cli/node_modules_prod/has-to-string-tag-x/.editorconfig npm-name-cli.noarch: W: hidden-file-or-dir /usr/lib/node_modules/npm-name-cli/node_modules_prod/has-to-string-tag-x/.eslintignore npm-name-cli.noarch: W: hidden-file-or-dir /usr/lib/node_modules/npm-name-cli/node_modules_prod/has-to-string-tag-x/.eslintrc.json npm-name-cli.noarch: W: hidden-file-or-dir /usr/lib/node_modules/npm-name-cli/node_modules_prod/has-to-string-tag-x/.nvmrc npm-name-cli.noarch: W: hidden-file-or-dir /usr/lib/node_modules/npm-name-cli/node_modules_prod/has-to-string-tag-x/.travis.yml npm-name-cli.noarch: W: hidden-file-or-dir /usr/lib/node_modules/npm-name-cli/node_modules_prod/has-to-string-tag-x/.uglifyjsrc.json npm-name-cli.noarch: W: hidden-file-or-dir /usr/lib/node_modules/npm-name-cli/node_modules_prod/is-arrayish/.editorconfig npm-name-cli.noarch: W: hidden-file-or-dir /usr/lib/node_modules/npm-name-cli/node_modules_prod/is-arrayish/.istanbul.yml npm-name-cli.noarch: W: hidden-file-or-dir /usr/lib/node_modules/npm-name-cli/node_modules_prod/is-arrayish/.npmignore npm-name-cli.noarch: W: hidden-file-or-dir /usr/lib/node_modules/npm-name-cli/node_modules_prod/is-arrayish/.travis.yml npm-name-cli.noarch: W: hidden-file-or-dir /usr/lib/node_modules/npm-name-cli/node_modules_prod/is-core-module/.eslintignore npm-name-cli.noarch: W: hidden-file-or-dir /usr/lib/node_modules/npm-name-cli/node_modules_prod/is-core-module/.eslintrc npm-name-cli.noarch: W: hidden-file-or-dir /usr/lib/node_modules/npm-name-cli/node_modules_prod/is-core-module/.github npm-name-cli.noarch: W: hidden-file-or-dir /usr/lib/node_modules/npm-name-cli/node_modules_prod/is-core-module/.github npm-name-cli.noarch: W: hidden-file-or-dir /usr/lib/node_modules/npm-name-cli/node_modules_prod/is-core-module/.nycrc npm-name-cli.noarch: W: hidden-file-or-dir /usr/lib/node_modules/npm-name-cli/node_modules_prod/is-object/.eslintignore npm-name-cli.noarch: W: hidden-file-or-dir /usr/lib/node_modules/npm-name-cli/node_modules_prod/is-object/.eslintrc npm-name-cli.noarch: W: hidden-file-or-dir /usr/lib/node_modules/npm-name-cli/node_modules_prod/is-object/.nycrc npm-name-cli.noarch: W: hidden-file-or-dir /usr/lib/node_modules/npm-name-cli/node_modules_prod/is-object/.testem.json npm-name-cli.noarch: W: hidden-file-or-dir /usr/lib/node_modules/npm-name-cli/node_modules_prod/isarray/.npmignore npm-name-cli.noarch: W: hidden-file-or-dir /usr/lib/node_modules/npm-name-cli/node_modules_prod/isarray/.travis.yml npm-name-cli.noarch: W: hidden-file-or-dir /usr/lib/node_modules/npm-name-cli/node_modules_prod/json-buffer/.travis.yml npm-name-cli.noarch: W: hidden-file-or-dir /usr/lib/node_modules/npm-name-cli/node_modules_prod/log-symbols/node_modules/color-name/.eslintrc.json npm-name-cli.noarch: W: hidden-file-or-dir /usr/lib/node_modules/npm-name-cli/node_modules_prod/log-symbols/node_modules/color-name/.npmignore npm-name-cli.noarch: W: hidden-file-or-dir /usr/lib/node_modules/npm-name-cli/node_modules_prod/minimist/.travis.yml npm-name-cli.noarch: E: script-without-shebang /usr/lib/node_modules/npm-name-cli/node_modules_prod/org-regex/package.json npm-name-cli.noarch: E: zero-length /usr/lib/node_modules/npm-name-cli/node_modules_prod/package-json/node_modules/@sindresorhus/is/dist/example.d.ts npm-name-cli.noarch: E: zero-length /usr/lib/node_modules/npm-name-cli/node_modules_prod/package-json/node_modules/@sindresorhus/is/dist/source/tests/test.d.ts npm-name-cli.noarch: W: hidden-file-or-dir /usr/lib/node_modules/npm-name-cli/node_modules_prod/package-json/node_modules/json-buffer/.npmignore npm-name-cli.noarch: W: hidden-file-or-dir /usr/lib/node_modules/npm-name-cli/node_modules_prod/package-json/node_modules/json-buffer/.travis.yml npm-name-cli.noarch: W: hidden-file-or-dir /usr/lib/node_modules/npm-name-cli/node_modules_prod/package-json/node_modules/registry-auth-token/.npmignore npm-name-cli.noarch: W: hidden-file-or-dir /usr/lib/node_modules/npm-name-cli/node_modules_prod/path-parse/.travis.yml npm-name-cli.noarch: W: hidden-file-or-dir /usr/lib/node_modules/npm-name-cli/node_modules_prod/pump/.travis.yml npm-name-cli.noarch: W: hidden-file-or-dir /usr/lib/node_modules/npm-name-cli/node_modules_prod/readable-stream/.travis.yml npm-name-cli.noarch: W: hidden-file-or-dir /usr/lib/node_modules/npm-name-cli/node_modules_prod/resolve/.editorconfig npm-name-cli.noarch: W: hidden-file-or-dir /usr/lib/node_modules/npm-name-cli/node_modules_prod/resolve/.eslintignore npm-name-cli.noarch: W: hidden-file-or-dir /usr/lib/node_modules/npm-name-cli/node_modules_prod/resolve/.eslintrc npm-name-cli.noarch: W: hidden-file-or-dir /usr/lib/node_modules/npm-name-cli/node_modules_prod/resolve/.github npm-name-cli.noarch: W: hidden-file-or-dir /usr/lib/node_modules/npm-name-cli/node_modules_prod/resolve/.github npm-name-cli.noarch: W: hidden-file-or-dir /usr/lib/node_modules/npm-name-cli/node_modules_prod/resolve/test/.eslintrc npm-name-cli.noarch: E: zero-length /usr/lib/node_modules/npm-name-cli/node_modules_prod/resolve/test/pathfilter/deep_ref/main.js npm-name-cli.noarch: E: zero-length /usr/lib/node_modules/npm-name-cli/node_modules_prod/resolve/test/resolver/baz/doom.js npm-name-cli.noarch: E: zero-length /usr/lib/node_modules/npm-name-cli/node_modules_prod/resolve/test/resolver/browser_field/a.js npm-name-cli.noarch: E: zero-length /usr/lib/node_modules/npm-name-cli/node_modules_prod/resolve/test/resolver/browser_field/b.js npm-name-cli.noarch: E: zero-length /usr/lib/node_modules/npm-name-cli/node_modules_prod/resolve/test/resolver/mug.coffee npm-name-cli.noarch: E: zero-length /usr/lib/node_modules/npm-name-cli/node_modules_prod/resolve/test/resolver/mug.js npm-name-cli.noarch: E: zero-length /usr/lib/node_modules/npm-name-cli/node_modules_prod/resolve/test/resolver/multirepo/packages/package-b/index.js npm-name-cli.noarch: E: zero-length /usr/lib/node_modules/npm-name-cli/node_modules_prod/resolve/test/resolver/other_path/lib/other-lib.js npm-name-cli.noarch: E: zero-length /usr/lib/node_modules/npm-name-cli/node_modules_prod/resolve/test/resolver/other_path/root.js npm-name-cli.noarch: E: zero-length /usr/lib/node_modules/npm-name-cli/node_modules_prod/resolve/test/resolver/symlinked/_/node_modules/foo.js npm-name-cli.noarch: W: hidden-file-or-dir /usr/lib/node_modules/npm-name-cli/node_modules_prod/resolve/test/resolver/symlinked/_/symlink_target/.gitkeep npm-name-cli.noarch: E: zero-length /usr/lib/node_modules/npm-name-cli/node_modules_prod/resolve/test/resolver/symlinked/_/symlink_target/.gitkeep npm-name-cli.noarch: E: zero-length /usr/lib/node_modules/npm-name-cli/node_modules_prod/resolve/test/shadowed_core/node_modules/util/index.js npm-name-cli.noarch: E: script-without-shebang /usr/lib/node_modules/npm-name-cli/node_modules_prod/squatter/node_modules/@szmarczak/http-timer/package.json npm-name-cli.noarch: W: hidden-file-or-dir /usr/lib/node_modules/npm-name-cli/node_modules_prod/squatter/node_modules/json-buffer/.npmignore npm-name-cli.noarch: W: hidden-file-or-dir /usr/lib/node_modules/npm-name-cli/node_modules_prod/squatter/node_modules/json-buffer/.travis.yml npm-name-cli.noarch: W: hidden-file-or-dir /usr/lib/node_modules/npm-name-cli/node_modules_prod/string_decoder/.travis.yml npm-name-cli.noarch: W: hidden-file-or-dir /usr/lib/node_modules/npm-name-cli/node_modules_prod/validate-npm-package-name/.npmignore npm-name-cli.noarch: W: hidden-file-or-dir /usr/lib/node_modules/npm-name-cli/node_modules_prod/validate-npm-package-name/.nyc_output npm-name-cli.noarch: W: hidden-file-or-dir /usr/lib/node_modules/npm-name-cli/node_modules_prod/validate-npm-package-name/.nyc_output npm-name-cli.noarch: W: hidden-file-or-dir /usr/lib/node_modules/npm-name-cli/node_modules_prod/validate-npm-package-name/.travis.yml npm-name-cli.noarch: W: hidden-file-or-dir /usr/lib/node_modules/npm-name-cli/node_modules_prod/wcwidth/.npmignore npm-name-cli.src: W: strange-permission check-null-licenses 755 npm-name-cli.src: W: no-%build-section npm-name-cli.src: W: invalid-url Source1: npm-name-cli-3.0.0-nm-prod.tgz 2 packages and 0 specfiles checked; 46 errors, 76 warnings. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
