Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: libao https://bugzilla.redhat.com/show_bug.cgi?id=225986 ------- Additional Comments From wolfy@xxxxxxxxxxxxxxxxxx 2007-11-14 19:38 EST ------- The package seems fine except for a minor unneeded dependency (alsa-lib-devel which is already pulled by esound-devel) The only suggestion I have is to replace the 5 successive grep calls with a single one (grep -v "item1\|item2\|...|itemn" ) Formal review will come a bit later, but my rpmlint and mock have no complains, the package builds just fine in devel/x86_64. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review