[Bug 1935379] Review Request: openconnect-gateway - Connect to a VPN without routing everything through the VPN

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1935379

Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |zebob.m@xxxxxxxxx
           Doc Type|---                         |If docs needed, set a value



--- Comment #1 from Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> ---
 - Why don't youu define the full commit like this:

%global commit0 627468b537befb16c0d04e426450b2fe7eb85c9f
%global shortcommit0 %(c=%{commit}; echo ${c:0:7})
%global date0   20170903

 - This is the opposite: date first, then short commit:

Release:        0.1.%{date0}git%{shortcommit0}%{?dist}

[…]

%changelog
* Thu Mar 04 2021 Raphael Groner <raphgro@xxxxxxxxxxxxxxxxx> -
0-0.1.20170903git627468b
- Initial package

 - Use then

%prep
%autosetup -n %{name}-%{commit0}

 - Use a better name for the archive:

Source0:        %{url}/archive/%{commit0}/%{name}-%{shortcommit0}.tar.gz

 - date should be the date you took the snapshot not the date of the commit


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux