https://bugzilla.redhat.com/show_bug.cgi?id=1901118 --- Comment #3 from Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> --- - I believe the main binary package should include the license as well: %files -n %{crate} %doc README.md %license LICENSE %{_bindir}/please %{_bindir}/pleaseedit %{_mandir}/man1/please.1* %{_mandir}/man5/please.ini.5* %config(noreplace) /etc/pam.d/please %config(noreplace) /etc/pam.d/pleaseedit %endif - You didn't add a comment above the patch explaining what you have changed. # Patch for syslog dependency # - Bump syslog to 0.5 Patch0: pleaser-fix-metadata.diff You also need to link to the upstream PR you opened bumping the dependency. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
