[Bug 1928969] Review Request: chatty - mobile libpurple messaging client

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1928969



--- Comment #5 from sorensentor@xxxxxxx ---
Spec URL: https://gitlab.com/fedora-mobile/chatty/-/raw/master/chatty.spec
SRPM URL:
https://download.copr.fedorainfracloud.org/results/njha/mobile/fedora-rawhide-x86_64/02074354-chatty/chatty-0.2.0-5.fc35.src.rpm
Copr Build: https://copr.fedorainfracloud.org/coprs/njha/mobile/build/2074354/

> - Package uses either %{buildroot} or $RPM_BUILD_ROOT
>  Note: Using both %{buildroot} and $RPM_BUILD_ROOT
>  See: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_macros

This has been addressed. 

> - The private library usage is... unfortunate. Is there any way to just disable
> the jabber support and not have to use it? Failing that, would it at least be possible
> to use the libpurple library at runtime? (currently this package installs the 
> kind of generic sounding /usr/lib64/libjabber.so which it gets from libpurple
> during build instead of the /usr/lib64/purple-2/libjabber.so). 
> Also if you can't use the libpurple one, make sure to add a 
> Provides: bundled(libjabber.so) per
> https://docs.fedoraproject.org/en-US/packaging-guidelines/#bundling

So, all other info regarding this being linked, the only thing I could figure
out to continue is to resume using the "hacky patch" and to update to use the
correct bundled() = [version] addition. 

Various other cleanups from the review as well (tabs/space etc...) 

Thanks again!


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux