[Bug 383271] Review Request: b43-firmware - V4 firmware for Broadcom wireless devices

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: b43-firmware -  V4 firmware for Broadcom wireless devices


https://bugzilla.redhat.com/show_bug.cgi?id=383271


notting@xxxxxxxxxx changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|                            |182235
              nThis|                            |
         AssignedTo|nobody@xxxxxxxxxxxxxxxxx    |notting@xxxxxxxxxx
               Flag|                            |fedora-review?




------- Additional Comments From notting@xxxxxxxxxx  2007-11-14 16:28 EST -------

MUST:
 - Package meets naming and packaging guidelines - OK
 - Spec file matches base package name. - OK
 - Spec has consistant macro usage. - OK
 - Meets Packaging Guidelines. - ***

*** The 'version' used is odd, and I don't see where it's coming from.

 - License - ***

*** If FE-Legal is OK, I suppose it's OK. We're sort of inferring the terms, though.

 - License field in spec matches - OK
 - License file included in package - OK
 - Spec in American English - OK
 - Spec is legible. - OK
 - Sources match upstream md5sum: ... download timed out.

 - Package needs ExcludeArch - ***

*** Might need Exclude/ExclusiveArch to match where driver is built. Is this
built on all arches?

 - BuildRequires correct - OK
 - Spec handles locales/find_lang - N/A
 - Package has %defattr and permissions on files is good. - OK
 - Package has a correct %clean section. - OK
 - Package has correct buildroot - OK
 - Package is code or permissible content. - OK
 - Doc subpackage needed/used.  - N/A
 - Packages %doc files don't affect runtime.  - OK
 - Package compiles and builds on at least one arch. - OK (noarch)
 - Package has no duplicate files in %files. - OK
 - Package doesn't own any directories other packages own.- OK
 - Package owns all the directories it creates.  - OK
 - No rpmlint output. - OK
 - final provides and requires are sane:

SHOULD Items:

 - Should build in mock. - OK (tested i386)
 - Should build on all supported archs - OK (noarch)
 - Should function as described. - didn't test, no hardware
 - Should have sane scriptlets. - N/A
 - Should have dist tag - N/A
 - Should package latest version - ... what is latest?


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]