Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: sgml-common https://bugzilla.redhat.com/show_bug.cgi?id=226415 pertusus@xxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pertusus@xxxxxxx ------- Additional Comments From pertusus@xxxxxxx 2007-11-14 15:45 EST ------- * BuildRoot is not among the preferred ones * the following requires seems wrong to me, they are old: Requires: sh-utils fileutils textutils what are they for? And the grep requires? * where comes sgml-common-automake.tar.gz from? shouldn't it better to take those files from the automake package? * url is lacking. Maybe http://www.math.ias.edu/doc/sgml-common-0.6.3/html/index.html * if some files come from jadetex, they should come from the upstream package * timestamps should be kept * rpm macros should used, and used consistently * where comes the CHANGES file from? * %makeinstall should certainly not be used * I don't think that the with-docdir patch is for fedora, it is for upstream. In fedora there are other ways to do it, maybe along make install.... htmldir=.... This would remove the need for autoconf/automake * the %clean section could be simplified There are certainly more issues, just try to fix as much as possible. Suggestion: change %defattr (-,root,root) to %defattr (-,root,root,-) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review