Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: sysusage - System monitoring based on perl, rrdtool, and sysstat https://bugzilla.redhat.com/show_bug.cgi?id=248395 ------- Additional Comments From tibbs@xxxxxxxxxxx 2007-11-14 15:13 EST ------- Found some time to get back to this. There are a few issues: rpmlint says: sysusage.noarch: W: invalid-license Artistic sysusage.noarch: W: invalid-license GPL This package has the usual "same terms as Perl" clause, so the License: tag should contain "GPL+ or Artistic" (http://fedoraproject.org/wiki/Licensing). This package assumes /var/www exists but doesn't require anything which would provide it. My understanding is that this isn't really a webapp, just a script which produces some web-visible output, but you still need to require httpd if you're going to assume /var/www is there. And that would mean that by default this package makes its output visible to the world, which isn't generally a good thing. A .htaccess or /etc/httpd/conf.d/sysusage.conf which restricts access to localhost is necessary in this case. It would be helpful to include some Fedora-specific documentation on how to actually make this package do something. I suppose it needs a crontab, and it would be nice to provide one although it mustn't do anything by default. The cacti package puts a sample crontab in /etc/cron.d/cacti which is commented out, many packages include a README.Fedora file with instructions on getting them to run and opening up any default access restrictions. Review checklist: * source files match upstream: 0486abce90c072bb2cd66abf999f08ed662e55be2f1d53e098f04ff9cf6b5de4 SysUsage-Sar-2.6.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. X license field needs a tweak. * license is open source-compatible. * license text not included upstream. * latest version is being packaged. * BuildRequires are proper (none) * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly X rpmlint has a valid complaint (license tag) X final provides and requires: config(sysusage) = 0:2.6-2.fc9 perl(SysUsage::Sar) = 2.6 sysusage = 0:2.6-2.fc9 = /usr/bin/perl config(sysusage) = 0:2.6-2.fc9 perl(Exporter) perl(File::Find) perl(FileHandle) perl(Getopt::Long) perl(Net::SMTP) perl(POSIX) perl(RRDs) perl(SysUsage::Sar) perl(strict) perl(vars) rrdtool sysstat (needs httpd for /var/www) * %check is not present; manual testing shows that things at least seem to run and produce proper output. X does not own /var/www/html, and depends on nothing which owns it. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review