Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ebview - EPWING CD-ROM dictionary viewer https://bugzilla.redhat.com/show_bug.cgi?id=382551 ------- Additional Comments From akahl@xxxxxxxxxxxxxx 2007-11-14 13:13 EST ------- Package Review * rpmlint remains silent * The package is named according to the Package Naming Guidelines * The spec file name matches the base package * Fedora approved license: GPLv2+ * License field in the package spec file matches the actual license * COPYING included * The spec file is written in American English * The spec file is legible * The sources used to build the package matches the upstream source: SHA1 47b63fb2f265c83cc5bf7aeb92f96d0e1cc7f9af * Builds on f8 x86_64 * BuildRequires look sane * Proper locale handling * No libraries * Package owns all directories it creates * No duplicates in %files * File permissions are sane * %clean starts with build root clean * Consistent use of macros * The package contains code * Documentation not large, no -doc subpackage needed * No header files * No static libs * No pkgconfig files * No library files * Desktop file handled properly (BuildRequires, %install, vendor id) * Package does not own files or directories already owned by other packages * %install starts with build root clean * All filenames are valid UTF-8 Additional checks: * Latest version is being packaged: 0.3.6 * Dist tag is present * Group tag is valid * Build root is correct: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) * Scriptlets look sane * Builds in mock (dist-f9) Only three questionable items: - /usr/share/ebview/about.jp is not UTF-8 but ISO-8859 encoded, is this necessary for the runtime? - ebview.spec:68: --with-eb-conf=%{_libdir}/eb.conf Neither does the package provide such a file nor does it belong there, according to ./configure --help output: " --with-eb-conf=FILE eb.conf file is FILE [default=SYSCONFDIR/eb.conf]" Configuration files should reside in %{_sysconfdir} and (if provided) handled properly in %files - On startup, pango warns (ebview:9142): Pango-WARNING **: couldn't load font "Sazanami Mincho 12", falling back to "Sans 12", expect ugly output. Since your scriptlet (re)defines the default font in src/preference.c to Sazanami, you should add a Require for this font. If the font is not available in Fedora yet, could you create a package for it? After clarification of these items I'm going to approve the package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review