https://bugzilla.redhat.com/show_bug.cgi?id=1933464 Davide Cavalca <dcavalca@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #8 from Davide Cavalca <dcavalca@xxxxxx> --- - the specfile in the src.rpm doesn't match the one in the URL; the delta is Diff spec file in url and in SRPM --------------------------------- --- /tmp/a/1933464-rubygem-sugarjar/srpm/rubygem-sugarjar.spec 2021-03-10 08:46:52.573469876 -0800 +++ /tmp/a/1933464-rubygem-sugarjar/srpm-unpacked/rubygem-sugarjar.spec 2021-03-09 23:50:59.000000000 -0800 @@ -67,5 +67,5 @@ %clean -rm -rf %{buildroot} +rm -rf $RPM_BUILD_ROOT %files -n sugarjar which isn't actually important - per fedora-review, you can actually delete the whole %clean section - consider adding a manpage for sj (ideally upstream) None of these are blocking, APPROVED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
