[Bug 1931055] Review Request: elementary-settings-daemon - Settings Daemon for Pantheon

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1931055



--- Comment #2 from Fabio Valentini <decathorpe@xxxxxxxxx> ---
(In reply to Robert-André Mauchin 🐧 from comment #1)

Thanks for the review!

>  - This should be the date you took the snapshot, not the date of the commit:
> 
> %global commitdate  20210219

I can't actually find anything about this in the Packaging Guidelines (neither
general, nor Versioning, nor SourceURL guidelines).

I'm unsure whether specifying the snapshot date is meaningful at all, since we
always assume that commit *hashes* are unique and can't be mutated (in contrast
to git tags, which can be deleted, created to point at a different commit, and
then force-pushed).


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux