[Bug 1929992] Review Request: python-wcmatch - Wildcard/glob file name matcher

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1929992



--- Comment #7 from Lumír Balhar <lbalhar@xxxxxxxxxx> ---
Quick comment related to the failing test: Upstream uses pytest so you can use
%pytest macro to run tests and then you should not ignore the results of the
tests by ` ||:` - better would be to skip just the one failing test.

See https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_macros

But feel free to wait for a more complete review and fix all possible issues at
once.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux