[Bug 1916190] Review Request: overlayfs-tools - OverlayFS layers manipulation tools

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1916190

Dominik 'Rathann' Mierzejewski <dominik@xxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?(dominik@greysecto |
                   |r.net)                      |



--- Comment #3 from Dominik 'Rathann' Mierzejewski <dominik@xxxxxxxxxxxxxx> ---
Thanks for the review!

(In reply to code from comment #2)
[...] 
> - The patch for errno.h should have been submitted upstream. I did it; you
>   should link https://github.com/kmxz/overlayfs-tools/issues/14 in a comment
>   above the patch.

Done.

> - You might want to patch https://github.com/kmxz/overlayfs-tools/pull/13 as
>   well, although this is strictly optional.

Done.

> - A man page would be nice. See
[...]
>   Or, if you are willing to keep it updated as needed, I can supply a
>   hand-written man page with slightly nicer formatting.

That would be best. I'll forward it upstream, too. I'll use help2man approach
you suggested in the meantime.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux