https://bugzilla.redhat.com/show_bug.cgi?id=1936425 Miro Hrončok <mhroncok@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mhroncok@xxxxxxxxxx --- Comment #2 from Miro Hrončok <mhroncok@xxxxxxxxxx> --- Suggestions: 1) https://github.com/python/python-docs-theme/ seems like a better URL for somebody who wants to actually see/modify the code of this. 2) `rm -rf %{pypi_name}.egg-info` is not needed with %pyproject-rpm-macros, they do this for you when needed. 3) About the %pypi_name macro: In this case, you can "just" use the %{name} macro instead of it, if you want. Note that e.g. `%autosetup -n %{name}-%{version}` == `%autosetup`. 4) I suggest removing the `# Created by pyp2rpm-3.3.5` comment, since not much has left from the spec file generated by pyp2rpm. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
