https://bugzilla.redhat.com/show_bug.cgi?id=1922315 Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@xxxxxxxxx --- Comment #6 from Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> --- 1) Please add comment explaining why this package has to use a specific commit hash Last release is from 2016, so I guess it's better to package the tip. CMakeLists.txt contains the actual version. 3) Rpmlint is complaining about, please solve it or add a waiver: wdt.src:119: E: hardcoded-library-path in %{_prefix}/lib wdt.src:128: E: hardcoded-library-path in %{_prefix}/lib/*.a Not an issue, they are renamed in the SPEC. - Source0: https://github.com/facebook/wdt/archive/%{commit}.tar.gz#/%{name}-%{commit}.tar.gz → Source0: https://github.com/facebook/wdt/archive/%{commit}/%{name}-%{commit}.tar.gz - To avoid unintentional soname bump, we recommend not globbing the soname version: %{_libdir}/*.so.1* -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
