https://bugzilla.redhat.com/show_bug.cgi?id=1918405 --- Comment #2 from Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> --- - How is this generated: Source1: %{npm_name}-%{version}-nm-dev.tgz Add a comment to explain it. - You unzip Source1 but do not run tests with it? %check %{__nodejs} -e 'require("./")' # Setup bundled dev node_modules for testing # Note: this cannot be in %%prep or the dev node_modules # can get pulled into the regular rpm tar xfz %{SOURCE1} - Package should start with: %{?nodejs_find_provides_and_requires} - %nodejs_symlink_deps should be run at the end of install - I suggest naming the package tiddlywiki if this is a standalone application - What's the point of Source2: %{npm_name}-%{version}-bundled-licenses.txt? There is already a "license" file with the BSD copy. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
