https://bugzilla.redhat.com/show_bug.cgi?id=1922315 --- Comment #4 from Jaroslav Škarvada <jskarvad@xxxxxxxxxx> --- - Is there any need for the static subpackage? We shouldn't ship static libs without strong reason, e.g. from the packaging guidelines [1]: "In general, packagers SHOULD NOT ship static libraries." - wdt-libs.x86_64: W: shared-lib-calls-exit /usr/lib64/libwdt_min.so.1.32.1910230 exit@GLIBC_2.2.5 This is not good for shared library, it should be reported to upstream. Generally, API errors shouldn't terminate the main program. But this is not review blocker. - Source0: https://github.com/facebook/wdt/archive/%{commit}.tar.gz#/%{name}-%{commit}.tar.gz This could be simplified to: Source0: https://github.com/facebook/wdt/archive/%{commit}/%{name}-%{commit}.tar.gz - https://github.com/facebook/wdt/blob/master/PATENTS This pose additional constraints to the license (line 14). Although I personally think it's OK, I opened fedora-legal ticket [2] to be 100% sure. [1] https://docs.fedoraproject.org/en-US/packaging-guidelines/#_packaging_static_libraries [2] https://lists.fedoraproject.org/archives/list/legal@xxxxxxxxxxxxxxxxxxxxxxx/thread/2AVHXQD3C2JBSZQT7E6HK3HHQ4O5KBDV/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
