[Bug 1935650] Review Request: rubygem-ffi-rzmq-core - This gem provides only the FFI wrapper for the ZeroMQ (0mq) networking library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1935650



--- Comment #6 from Jarek Prokop <jprokop@xxxxxxxxxx> ---
(In reply to Pavel Valena from comment #4)
> (In reply to Jarek Prokop from comment #2)
> > (In reply to Pavel Valena from comment #1)
> </snip>
> > > we need to specify so arch-specific dependencies with richdeps (if
> > > libffi...). On the upside, there's no need for the patch.
> > 
> > There is because the library is using hardcoded to search for `libzmq.so`[0]
> > which is only in the `zeromq-devel` and that package pulls in many
> > unnecessary devel dependencies (and libzmq.so is not present not even via
> > symlink in the bare `zeromq` package).
> 
> Ah, sorry, I didn't check the patch and thought it's doing something
> different. Yes, we don't want zeromq-devel. Isn't that a bug, though?
> 
> Denis, could you comment, please?

Hmm, looks like at least according to ruby-ffi[1] wiki it does not seem like a
bug on our end.

> 
> > 
> > [0] the line gets expanded into `libzmq.so` specifically, so if we require
> > `libzmq.so.5` in spec it would pull in zeromq, but it would not work.
> 
> Jarku, if it's a correct soname, can you create a PR upstream?

I think it should look not only for `libzmq.so` (which seems like the preferred
upstream approach) but also for `libzmq.so.5`.
I'll open a PR upstream and add a comment with a PR link to the spec once I do
so.

> 
> > 
> > 
> > [0]
> > https://github.com/chuckremes/ffi-rzmq-core/blob/master/lib/ffi-rzmq-core/
> > libzmq.rb#L39

[1] https://github.com/ffi/ffi/wiki/Loading-Libraries#linux-packages


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux