[Bug 1910504] Review Request: libucl - Universal configuration library parser

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1910504



--- Comment #8 from Timothée Floure <timothee.floure@xxxxxxxxxx> ---
SPEC URL:
https://git.sr.ht/~fnux/hikari-rpm/blob/3fbdef61709ccb7102cffe3ccc6f39b78ed84f37/libucl/libucl.spec
SRPM URL:
https://kojipkgs.fedoraproject.org//work/tasks/7366/63207366/libucl-0.8.1-2.fc33.src.rpm

> The upstream package contains bindings for Python, Lua, and Haskell. All of these would be useful in Fedora. I think the package is incomplete without these language bindings.

I built the python bindings since it was a low-hanging fruit. I'll build the
lua and haskell ones later on / on demand, if needed.

> “V=1 make %{?_smp_mflags}” would be better expressed as “%make_build”, and “V=1 make %{?_smp_mflags} check” would be better expressed as “%make_build check”.

Fixed.

> An accepted change for Fedora 34 is that packages using make must BR it explicitly (“BuildRequires: make”). The guidelines have not yet been updated.

Fixed.

> Bundled libraries.

The build system is a pain and does not seem to eat includes properly. I kept
the partially-bundled libraries in but marked themo so.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux