https://bugzilla.redhat.com/show_bug.cgi?id=1928586 Raphael Groner <projects.rg@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |projects.rg@xxxxxxxx --- Comment #2 from Raphael Groner <projects.rg@xxxxxxxx> --- Some hints to your spec file: o description line is too long, have to break down into multiple line o add BuildRequires: gcc o may additionally to BR add also Requires: procps-ng - is that a weak dependency, why Fedora only? o please consider to generate documentation and ship in a doc subpackage o execute provided tests in %check o use systemd macros in %post and %postun https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_systemd Are you interested in a review swap? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
